Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/class-wc-order.php

Summary

Maintainability
F
1 wk
Test Coverage

WC_Order has 126 functions (exceeds 20 allowed). Consider refactoring.
Open

class WC_Order extends WC_Abstract_Order {

    /**
     * Stores data about status changes so relevant hooks can be fired.
     *
Severity: Major
Found in includes/class-wc-order.php - About 2 days to fix

    File class-wc-order.php has 950 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Regular order
 *
 * @package WooCommerce\Classes
    Severity: Major
    Found in includes/class-wc-order.php - About 2 days to fix

      Function needs_processing has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          public function needs_processing() {
        $transient_name   = 'wc_order_' . $this->get_id() . '_needs_processing';
        $needs_processing = get_transient( $transient_name );

        if ( false === $needs_processing ) {
      Severity: Minor
      Found in includes/class-wc-order.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_downloadable_items has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function get_downloadable_items() {
        $downloads = array();

        foreach ( $this->get_items() as $item ) {
            if ( ! is_object( $item ) ) {
      Severity: Minor
      Found in includes/class-wc-order.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_order_note has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function add_order_note( $note, $is_customer_note = 0, $added_by_user = false ) {
        if ( ! $this->get_id() ) {
            return 0;
        }
      Severity: Minor
      Found in includes/class-wc-order.php - About 1 hr to fix

        Method payment_complete has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function payment_complete( $transaction_id = '' ) {
        if ( ! $this->get_id() ) { // Order must exist.
            return false;
        }
        Severity: Minor
        Found in includes/class-wc-order.php - About 1 hr to fix

          Function get_formatted_order_total has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function get_formatted_order_total( $tax_display = '', $display_refunded = true ) {
        $formatted_total = wc_price( $this->get_total(), array( 'currency' => $this->get_currency() ) );
        $order_total     = $this->get_total();
        $total_refunded  = $this->get_total_refunded();
        $tax_string      = '';
          Severity: Minor
          Found in includes/class-wc-order.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method get_downloadable_items has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_downloadable_items() {
        $downloads = array();

        foreach ( $this->get_items() as $item ) {
            if ( ! is_object( $item ) ) {
          Severity: Minor
          Found in includes/class-wc-order.php - About 1 hr to fix

            Method status_transition has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function status_transition() {
        $status_transition = $this->status_transition;

        // Reset status transition variable.
        $this->status_transition = false;
            Severity: Minor
            Found in includes/class-wc-order.php - About 1 hr to fix

              Function status_transition has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function status_transition() {
        $status_transition = $this->status_transition;

        // Reset status transition variable.
        $this->status_transition = false;
              Severity: Minor
              Found in includes/class-wc-order.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method get_formatted_order_total has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function get_formatted_order_total( $tax_display = '', $display_refunded = true ) {
        $formatted_total = wc_price( $this->get_total(), array( 'currency' => $this->get_currency() ) );
        $order_total     = $this->get_total();
        $total_refunded  = $this->get_total_refunded();
        $tax_string      = '';
              Severity: Minor
              Found in includes/class-wc-order.php - About 1 hr to fix

                Function set_address_prop has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function set_address_prop( $prop, $address, $value ) {
        if ( array_key_exists( $prop, $this->data[ $address ] ) ) {
            if ( true === $this->object_read ) {
                if ( $value !== $this->data[ $address ][ $prop ] || ( isset( $this->changes[ $address ] ) && array_key_exists( $prop, $this->changes[ $address ] ) ) ) {
                    $this->changes[ $address ][ $prop ] = $value;
                Severity: Minor
                Found in includes/class-wc-order.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function payment_complete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function payment_complete( $transaction_id = '' ) {
        if ( ! $this->get_id() ) { // Order must exist.
            return false;
        }
                Severity: Minor
                Found in includes/class-wc-order.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_tax_refunded_for_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_tax_refunded_for_item( $item_id, $tax_id, $item_type = 'line_item' ) {
        $total = 0;
        foreach ( $this->get_refunds() as $refund ) {
            foreach ( $refund->get_items( $item_type ) as $refunded_item ) {
                $refunded_item_id = (int) $refunded_item->get_meta( '_refunded_item_id' );
                Severity: Minor
                Found in includes/class-wc-order.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_changes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_changes() {
        $changed_props = parent::get_changes();
        $subs          = array( 'shipping', 'billing' );
        foreach ( $subs as $sub ) {
            if ( ! empty( $changed_props[ $sub ] ) ) {
                Severity: Minor
                Found in includes/class-wc-order.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function has_downloadable_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function has_downloadable_item() {
        foreach ( $this->get_items() as $item ) {
            if ( $item->is_type( 'line_item' ) ) {
                $product = $item->get_product();
                Severity: Minor
                Found in includes/class-wc-order.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_total_tax_refunded_by_rate_id has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_total_tax_refunded_by_rate_id( $rate_id ) {
        $total = 0;
        foreach ( $this->get_refunds() as $refund ) {
            foreach ( $refund->get_items( 'tax' ) as $refunded_item ) {
                if ( absint( $refunded_item->get_rate_id() ) === $rate_id ) {
                Severity: Minor
                Found in includes/class-wc-order.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_qty_refunded_for_item has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_qty_refunded_for_item( $item_id, $item_type = 'line_item' ) {
        $qty = 0;
        foreach ( $this->get_refunds() as $refund ) {
            foreach ( $refund->get_items( $item_type ) as $refunded_item ) {
                if ( absint( $refunded_item->get_meta( '_refunded_item_id' ) ) === $item_id ) {
                Severity: Minor
                Found in includes/class-wc-order.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function get_total_refunded_for_item has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_total_refunded_for_item( $item_id, $item_type = 'line_item' ) {
        $total = 0;
        foreach ( $this->get_refunds() as $refund ) {
            foreach ( $refund->get_items( $item_type ) as $refunded_item ) {
                if ( absint( $refunded_item->get_meta( '_refunded_item_id' ) ) === $item_id ) {
                Severity: Minor
                Found in includes/class-wc-order.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    protected function get_address_prop( $prop, $address = 'billing', $context = 'view' ) {
        $value = null;

        if ( array_key_exists( $prop, $this->data[ $address ] ) ) {
            $value = isset( $this->changes[ $address ][ $prop ] ) ? $this->changes[ $address ][ $prop ] : $this->data[ $address ][ $prop ];
                Severity: Major
                Found in includes/class-wc-order.php and 1 other location - About 3 hrs to fix
                includes/class-wc-customer.php on lines 431..442

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 143.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    protected function set_address_prop( $prop, $address, $value ) {
        if ( array_key_exists( $prop, $this->data[ $address ] ) ) {
            if ( true === $this->object_read ) {
                if ( $value !== $this->data[ $address ][ $prop ] || ( isset( $this->changes[ $address ] ) && array_key_exists( $prop, $this->changes[ $address ] ) ) ) {
                    $this->changes[ $address ][ $prop ] = $value;
                Severity: Major
                Found in includes/class-wc-order.php and 1 other location - About 2 hrs to fix
                includes/class-wc-customer.php on lines 862..872

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 139.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function get_total_refunded() {
        $cache_key   = WC_Cache_Helper::get_cache_prefix( 'orders' ) . 'total_refunded' . $this->get_id();
        $cached_data = wp_cache_get( $cache_key, $this->cache_group );

        if ( false !== $cached_data ) {
                Severity: Major
                Found in includes/class-wc-order.php and 2 other locations - About 55 mins to fix
                includes/class-wc-order.php on lines 1849..1862
                includes/class-wc-order.php on lines 1870..1883

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function get_total_tax_refunded() {
        $cache_key   = WC_Cache_Helper::get_cache_prefix( 'orders' ) . 'total_tax_refunded' . $this->get_id();
        $cached_data = wp_cache_get( $cache_key, $this->cache_group );

        if ( false !== $cached_data ) {
                Severity: Major
                Found in includes/class-wc-order.php and 2 other locations - About 55 mins to fix
                includes/class-wc-order.php on lines 1828..1841
                includes/class-wc-order.php on lines 1870..1883

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function get_total_shipping_refunded() {
        $cache_key   = WC_Cache_Helper::get_cache_prefix( 'orders' ) . 'total_shipping_refunded' . $this->get_id();
        $cached_data = wp_cache_get( $cache_key, $this->cache_group );

        if ( false !== $cached_data ) {
                Severity: Major
                Found in includes/class-wc-order.php and 2 other locations - About 55 mins to fix
                includes/class-wc-order.php on lines 1828..1841
                includes/class-wc-order.php on lines 1849..1862

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        try {
            do_action( 'woocommerce_pre_payment_complete', $this->get_id() );

            if ( WC()->session ) {
                WC()->session->set( 'order_awaiting_payment', false );
                Severity: Minor
                Found in includes/class-wc-order.php and 1 other location - About 30 mins to fix
                includes/class-wc-order.php on lines 331..348

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 91.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        try {
            $this->set_status( $new_status, $note, $manual );
            $this->save();
        } catch ( Exception $e ) {
            $logger = wc_get_logger();
                Severity: Minor
                Found in includes/class-wc-order.php and 1 other location - About 30 mins to fix
                includes/class-wc-order.php on lines 104..142

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 91.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status