woothemes/woocommerce

View on GitHub
includes/class-wc-regenerate-images-request.php

Summary

Maintainability
C
1 day
Test Coverage

Function filter_image_sizes_to_only_missing_thumbnails has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public function filter_image_sizes_to_only_missing_thumbnails( $sizes, $metadata, $attachment_id = null ) {
        $attachment_id = is_null( $attachment_id ) ? $this->attachment_id : $attachment_id;

        if ( ! $sizes || ! $attachment_id ) {
            return $sizes;
Severity: Minor
Found in includes/class-wc-regenerate-images-request.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function task has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function task( $item ) {
        if ( ! is_array( $item ) && ! isset( $item['attachment_id'] ) ) {
            return false;
        }

Severity: Minor
Found in includes/class-wc-regenerate-images-request.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method task has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function task( $item ) {
        if ( ! is_array( $item ) && ! isset( $item['attachment_id'] ) ) {
            return false;
        }

Severity: Major
Found in includes/class-wc-regenerate-images-request.php - About 2 hrs to fix

    Method filter_image_sizes_to_only_missing_thumbnails has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function filter_image_sizes_to_only_missing_thumbnails( $sizes, $metadata, $attachment_id = null ) {
            $attachment_id = is_null( $attachment_id ) ? $this->attachment_id : $attachment_id;
    
            if ( ! $sizes || ! $attachment_id ) {
                return $sizes;
    Severity: Minor
    Found in includes/class-wc-regenerate-images-request.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in includes/class-wc-regenerate-images-request.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status