Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/data-stores/class-wc-product-variable-data-store-cpt.php

Summary

Maintainability
F
5 days
Test Coverage

Function read_variation_attributes has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

    public function read_variation_attributes( &$product ) {
        global $wpdb;

        $variation_attributes = array();
        $attributes           = $product->get_attributes();
Severity: Minor
Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function read_price_data has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    public function read_price_data( &$product, $for_display = false ) {

        /**
         * Transient name for storing prices for this product (note: Max transient length is 45)
         *
Severity: Minor
Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File class-wc-product-variable-data-store-cpt.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * File for WC Variable Product Data Store class.
 *
 * @package WooCommerce\Classes
Severity: Minor
Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 6 hrs to fix

    Function read_attributes has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function read_attributes( &$product ) {
        $meta_attributes = get_post_meta( $product->get_id(), '_product_attributes', true );

        if ( ! empty( $meta_attributes ) && is_array( $meta_attributes ) ) {
            $attributes   = array();
    Severity: Minor
    Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method read_price_data has 98 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function read_price_data( &$product, $for_display = false ) {

        /**
         * Transient name for storing prices for this product (note: Max transient length is 45)
         *
    Severity: Major
    Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 3 hrs to fix

      Method read_variation_attributes has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function read_variation_attributes( &$product ) {
        global $wpdb;

        $variation_attributes = array();
        $attributes           = $product->get_attributes();
      Severity: Major
      Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 2 hrs to fix

        Method read_attributes has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function read_attributes( &$product ) {
        $meta_attributes = get_post_meta( $product->get_id(), '_product_attributes', true );

        if ( ! empty( $meta_attributes ) && is_array( $meta_attributes ) ) {
            $attributes   = array();
        Severity: Major
        Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 2 hrs to fix

          Function sync_managed_variation_stock_status has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              public function sync_managed_variation_stock_status( &$product ) {
        global $wpdb;

        if ( $product->get_manage_stock() ) {
            $children = $product->get_children();
          Severity: Minor
          Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method read_children has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function read_children( &$product, $force_read = false ) {
        $children_transient_name = 'wc_product_children_' . $product->get_id();
        $children                = get_transient( $children_transient_name );

        if ( empty( $children ) || ! is_array( $children ) || ! isset( $children['all'] ) || ! isset( $children['visible'] ) || $force_read ) {
          Severity: Minor
          Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 1 hr to fix

            Function sync_price has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function sync_price( &$product ) {
        global $wpdb;

        $children = $product->get_visible_children();
        if ( $children ) {
            Severity: Minor
            Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method delete_variations has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function delete_variations( $product_id, $force_delete = false ) {
        if ( ! is_numeric( $product_id ) || 0 >= $product_id ) {
            return;
        }
            Severity: Minor
            Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 1 hr to fix

              Function delete_variations has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function delete_variations( $product_id, $force_delete = false ) {
        if ( ! is_numeric( $product_id ) || 0 >= $product_id ) {
            return;
        }
              Severity: Minor
              Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get_price_hash has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function get_price_hash( &$product, $for_display = false ) {
        global $wp_filter;

        $price_hash   = $for_display && wc_tax_enabled() ? array( get_option( 'woocommerce_tax_display_shop', 'excl' ), WC_Tax::get_rates() ) : array( false );
        $filter_names = array( 'woocommerce_variation_prices_price', 'woocommerce_variation_prices_regular_price', 'woocommerce_variation_prices_sale_price' );
              Severity: Minor
              Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function child_has_dimensions( $product ) {
        global $wpdb;
        $children = $product->get_visible_children();
        if ( ! $children ) {
            return false;
              Severity: Major
              Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php and 1 other location - About 1 hr to fix
              includes/data-stores/class-wc-product-variable-data-store-cpt.php on lines 424..435

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 119.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function child_has_weight( $product ) {
        global $wpdb;
        $children = $product->get_visible_children();
        if ( ! $children ) {
            return false;
              Severity: Major
              Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php and 1 other location - About 1 hr to fix
              includes/data-stores/class-wc-product-variable-data-store-cpt.php on lines 445..456

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 119.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                          if ( 'incl' === get_option( 'woocommerce_tax_display_shop' ) ) {
                                $price         = '' === $price ? '' : wc_get_price_including_tax(
                                    $variation,
                                    array(
                                        'qty'   => 1,
              Severity: Major
              Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php and 1 other location - About 1 hr to fix
              includes/data-stores/class-wc-product-variable-data-store-cpt.php on lines 337..359

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 115.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                          } else {
                                $price         = '' === $price ? '' : wc_get_price_excluding_tax(
                                    $variation,
                                    array(
                                        'qty'   => 1,
              Severity: Major
              Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php and 1 other location - About 1 hr to fix
              includes/data-stores/class-wc-product-variable-data-store-cpt.php on lines 315..359

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 115.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              if ( ! empty( $meta_value['is_taxonomy'] ) ) {
                    if ( ! taxonomy_exists( $meta_value['name'] ) ) {
                        continue;
                    }
                    $id      = wc_attribute_taxonomy_id_by_name( $meta_value['name'] );
              Severity: Major
              Found in includes/data-stores/class-wc-product-variable-data-store-cpt.php and 1 other location - About 1 hr to fix
              includes/data-stores/class-wc-product-data-store-cpt.php on lines 463..472

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status