Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/data-stores/class-wc-product-variation-data-store-cpt.php

Summary

Maintainability
D
2 days
Test Coverage

File class-wc-product-variation-data-store-cpt.php has 330 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Class WC_Product_Variation_Data_Store_CPT file.
 *
 * @package WooCommerce\DataStores
Severity: Minor
Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 3 hrs to fix

    Method read_product_data has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function read_product_data( &$product ) {
        $id = $product->get_id();

        $product->set_props(
            array(
    Severity: Major
    Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 2 hrs to fix

      Method update has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function update( &$product ) {
        $product->save_meta_data();

        if ( ! $product->get_date_created() ) {
            $product->set_date_created( time() );
      Severity: Major
      Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 2 hrs to fix

        Method read has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function read( &$product ) {
        $product->set_defaults();

        if ( ! $product->get_id() ) {
            return;
        Severity: Minor
        Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 1 hr to fix

          Method create has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function create( &$product ) {
        if ( ! $product->get_date_created() ) {
            $product->set_date_created( time() );
        }
          Severity: Minor
          Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 1 hr to fix

            Function update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function update( &$product ) {
        $product->save_meta_data();

        if ( ! $product->get_date_created() ) {
            $product->set_date_created( time() );
            Severity: Minor
            Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function generate_product_title has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function generate_product_title( $product ) {
        $attributes = (array) $product->get_attributes();

        // Do not include attributes if the product has 3+ attributes.
        $should_include_attributes = count( $attributes ) < 3;
            Severity: Minor
            Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function read has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function read( &$product ) {
        $product->set_defaults();

        if ( ! $product->get_id() ) {
            return;
            Severity: Minor
            Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function read_product_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function read_product_data( &$product ) {
        $id = $product->get_id();

        $product->set_props(
            array(
            Severity: Minor
            Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function update_attributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function update_attributes( &$product, $force = false ) {
        $changes = $product->get_changes();

        if ( $force || array_key_exists( 'attributes', $changes ) ) {
            global $wpdb;
            Severity: Minor
            Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function update_post_meta( &$product, $force = false ) {
        $meta_key_to_props = array(
            '_variation_description' => 'description',
        );
            Severity: Major
            Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php and 1 other location - About 2 hrs to fix
            includes/data-stores/class-wc-product-grouped-data-store-cpt.php on lines 26..42

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 130.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        if ( doing_action( 'save_post' ) ) {
                $GLOBALS['wpdb']->update( $GLOBALS['wpdb']->posts, $post_data, array( 'ID' => $product->get_id() ) );
                clean_post_cache( $product->get_id() );
            } else {
                wp_update_post( array_merge( array( 'ID' => $product->get_id() ), $post_data ) );
            Severity: Major
            Found in includes/data-stores/class-wc-product-variation-data-store-cpt.php and 3 other locations - About 30 mins to fix
            includes/data-stores/abstract-wc-order-data-store-cpt.php on lines 165..170
            includes/data-stores/class-wc-coupon-data-store-cpt.php on lines 181..186
            includes/data-stores/class-wc-product-data-store-cpt.php on lines 239..244

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status