Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/gateways/paypal/class-wc-gateway-paypal.php

Summary

Maintainability
D
1 day
Test Coverage

File class-wc-gateway-paypal.php has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * PayPal Standard Payment Gateway.
 *
 * Provides a PayPal Standard Payment Gateway.
Severity: Minor
Found in includes/gateways/paypal/class-wc-gateway-paypal.php - About 2 hrs to fix

    Method get_icon_image has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function get_icon_image( $country ) {
        switch ( $country ) {
            case 'US':
            case 'NZ':
            case 'CZ':
    Severity: Major
    Found in includes/gateways/paypal/class-wc-gateway-paypal.php - About 2 hrs to fix

      Function get_icon_image has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function get_icon_image( $country ) {
        switch ( $country ) {
            case 'US':
            case 'NZ':
            case 'CZ':
      Severity: Minor
      Found in includes/gateways/paypal/class-wc-gateway-paypal.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct() {
        $this->id                = 'paypal';
        $this->has_fields        = false;
        $this->order_button_text = __( 'Proceed to PayPal', 'woocommerce' );
        $this->method_title      = __( 'PayPal Standard', 'woocommerce' );
      Severity: Minor
      Found in includes/gateways/paypal/class-wc-gateway-paypal.php - About 1 hr to fix

        Function capture_payment has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function capture_payment( $order_id ) {
        $order = wc_get_order( $order_id );

        if ( 'paypal' === $order->get_payment_method() && 'pending' === $order->get_meta( '_paypal_status', true ) && $order->get_transaction_id() ) {
            $this->init_api();
        Severity: Minor
        Found in includes/gateways/paypal/class-wc-gateway-paypal.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct() {
        $this->id                = 'paypal';
        $this->has_fields        = false;
        $this->order_button_text = __( 'Proceed to PayPal', 'woocommerce' );
        $this->method_title      = __( 'PayPal Standard', 'woocommerce' );
        Severity: Minor
        Found in includes/gateways/paypal/class-wc-gateway-paypal.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $countries     = array( 'DZ', 'AU', 'BH', 'BQ', 'BW', 'CA', 'CN', 'CW', 'FI', 'FR', 'DE', 'GR', 'HK', 'ID', 'JO', 'KE', 'KW', 'LU', 'MY', 'MA', 'OM', 'PH', 'PL', 'PT', 'QA', 'IE', 'RU', 'BL', 'SX', 'MF', 'SA', 'SG', 'SK', 'KR', 'SS', 'TW', 'TH', 'AE', 'GB', 'US', 'VN' );
        Severity: Major
        Found in includes/gateways/paypal/class-wc-gateway-paypal.php and 1 other location - About 2 hrs to fix
        includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 343..385

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 131.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status