Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/legacy/api/v3/class-wc-api-coupons.php

Summary

Maintainability
F
1 mo
Test Coverage

Function edit_coupon has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    public function edit_coupon( $id, $data ) {

        try {
            if ( ! isset( $data['coupon'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_coupon_data', sprintf( __( 'No %1$s data specified to edit %1$s', 'woocommerce' ), 'coupon' ), 400 );
Severity: Minor
Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File class-wc-api-coupons.php has 349 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * WooCommerce API Coupons Class
 *
 * Handles requests to the /coupons endpoint
Severity: Minor
Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 4 hrs to fix

    Method edit_coupon has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function edit_coupon( $id, $data ) {

        try {
            if ( ! isset( $data['coupon'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_coupon_data', sprintf( __( 'No %1$s data specified to edit %1$s', 'woocommerce' ), 'coupon' ), 400 );
    Severity: Major
    Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 3 hrs to fix

      Method create_coupon has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function create_coupon( $data ) {
        global $wpdb;

        try {
            if ( ! isset( $data['coupon'] ) ) {
      Severity: Major
      Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 3 hrs to fix

        Function bulk has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            public function bulk( $data ) {

        try {
            if ( ! isset( $data['coupons'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_coupons_data', sprintf( __( 'No %1$s data specified to create/edit %1$s', 'woocommerce' ), 'coupons' ), 400 );
        Severity: Minor
        Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method bulk has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function bulk( $data ) {

        try {
            if ( ! isset( $data['coupons'] ) ) {
                throw new WC_API_Exception( 'woocommerce_api_missing_coupons_data', sprintf( __( 'No %1$s data specified to create/edit %1$s', 'woocommerce' ), 'coupons' ), 400 );
        Severity: Minor
        Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 1 hr to fix

          Method get_coupon has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_coupon( $id, $fields = null ) {
        try {

            $id = $this->validate_request( $id, 'shop_coupon', 'read' );
          Severity: Minor
          Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 1 hr to fix

            Function create_coupon has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function create_coupon( $data ) {
        global $wpdb;

        try {
            if ( ! isset( $data['coupon'] ) ) {
            Severity: Minor
            Found in includes/legacy/api/v3/class-wc-api-coupons.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            <?php
/**
 * WooCommerce API Coupons Class
 *
 * Handles requests to the /coupons endpoint
            Severity: Major
            Found in includes/legacy/api/v3/class-wc-api-coupons.php and 1 other location - About 3 wks to fix
            includes/legacy/api/v2/class-wc-api-coupons.php on lines 1..575

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 4403.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status