Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php

Summary

Maintainability
D
1 day
Test Coverage

Method register_routes has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function register_routes() {
        register_rest_route( $this->namespace, '/' . $this->rest_base, array(
            'args' => array(
                'order_id'  => array(
                    'description' => __( 'The order ID.', 'woocommerce' ),
Severity: Major
Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php - About 2 hrs to fix

    Method get_item_schema has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'order_note',
            'type'       => 'object',
    Severity: Minor
    Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return $response;
      Severity: Major
      Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                register_rest_route( $this->namespace, '/' . $this->rest_base, array(
            'args' => array(
                'order_id'  => array(
                    'description' => __( 'The order ID.', 'woocommerce' ),
                    'type'        => 'integer',
        Severity: Major
        Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php and 1 other location - About 6 hrs to fix
        includes/rest-api/Controllers/Version1/class-wc-rest-product-attribute-terms-v1-controller.php on lines 43..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 208.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                $links    = array(
            'self' => array(
                'href' => rest_url( sprintf( '/%s/%s/%d', $this->namespace, $base, $note->comment_ID ) ),
            ),
            'collection' => array(
        Severity: Major
        Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php and 2 other locations - About 1 hr to fix
        includes/rest-api/Controllers/Version1/class-wc-rest-product-reviews-v1-controller.php on lines 499..509
        includes/rest-api/Controllers/Version1/class-wc-rest-webhook-deliveries-v1-controller.php on lines 199..209

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function get_item_permissions_check( $request ) {
        $order = wc_get_order( (int) $request['order_id'] );

        if ( $order && ! wc_rest_check_post_permissions( $this->post_type, 'read', $order->get_id() ) ) {
            return new WP_Error( 'woocommerce_rest_cannot_view', __( 'Sorry, you cannot view this resource.', 'woocommerce' ), array( 'status' => rest_authorization_required_code() ) );
        Severity: Minor
        Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php and 1 other location - About 55 mins to fix
        includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php on lines 165..173

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function delete_item_permissions_check( $request ) {
        $order = wc_get_order( (int) $request['order_id'] );

        if ( $order && ! wc_rest_check_post_permissions( $this->post_type, 'delete', $order->get_id() ) ) {
            return new WP_Error( 'woocommerce_rest_cannot_delete', __( 'Sorry, you are not allowed to delete this resource.', 'woocommerce' ), array( 'status' => rest_authorization_required_code() ) );
        Severity: Minor
        Found in includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php and 1 other location - About 55 mins to fix
        includes/rest-api/Controllers/Version1/class-wc-rest-order-notes-v1-controller.php on lines 148..156

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status