Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php

Summary

Maintainability
F
5 days
Test Coverage

File class-wc-rest-taxes-v1-controller.php has 447 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * REST API Taxes controller
 *
 * Handles requests to the /taxes endpoint.
Severity: Minor
Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 6 hrs to fix

    Method get_item_schema has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'tax',
            'type'       => 'object',
    Severity: Major
    Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 2 hrs to fix

      Method register_routes has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_routes() {
        register_rest_route( $this->namespace, '/' . $this->rest_base, array(
            array(
                'methods'             => WP_REST_Server::READABLE,
                'callback'            => array( $this, 'get_items' ),
      Severity: Major
      Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 2 hrs to fix

        Method get_items has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function get_items( $request ) {
        global $wpdb;

        $prepared_args = array();
        $prepared_args['order']  = $request['order'];
        Severity: Major
        Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 2 hrs to fix

          Method get_collection_params has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_collection_params() {
        $params                       = array();
        $params['context']            = $this->get_context_param();
        $params['context']['default'] = 'view';
          Severity: Major
          Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 2 hrs to fix

            Function create_or_update_tax has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function create_or_update_tax( $request, $current = null ) {
        $id          = absint( isset( $request['id'] ) ? $request['id'] : 0 );
        $data        = array();
        $fields      = array(
            'tax_rate_country',
            Severity: Minor
            Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create_or_update_tax has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function create_or_update_tax( $request, $current = null ) {
        $id          = absint( isset( $request['id'] ) ? $request['id'] : 0 );
        $data        = array();
        $fields      = array(
            'tax_rate_country',
            Severity: Minor
            Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 1 hr to fix

              Method prepare_item_for_response has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function prepare_item_for_response( $tax, $request ) {
        global $wpdb;

        $id   = (int) $tax->tax_rate_id;
        $data = array(
              Severity: Minor
              Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 1 hr to fix

                Function get_items has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_items( $request ) {
        global $wpdb;

        $prepared_args = array();
        $prepared_args['order']  = $request['order'];
                Severity: Minor
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    public function register_routes() {
        register_rest_route( $this->namespace, '/' . $this->rest_base, array(
            array(
                'methods'             => WP_REST_Server::READABLE,
                'callback'            => array( $this, 'get_items' ),
                Severity: Major
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php and 2 other locations - About 2 days to fix
                includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 56..118
                includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 59..133

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 484.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    protected function prepare_links( $tax ) {
        $links = array(
            'self' => array(
                'href' => rest_url( sprintf( '/%s/%s/%d', $this->namespace, $this->rest_base, $tax->tax_rate_id ) ),
            ),
                Severity: Major
                Found in includes/rest-api/Controllers/Version1/class-wc-rest-taxes-v1-controller.php and 2 other locations - About 40 mins to fix
                includes/rest-api/Controllers/Version1/class-wc-rest-customers-v1-controller.php on lines 607..618
                includes/rest-api/Controllers/Version3/class-wc-rest-data-controller.php on lines 142..153

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status