Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php

Summary

Maintainability
F
1 wk
Test Coverage

Method get_item_schema has 194 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => $this->post_type,
            'type'       => 'object',
Severity: Major
Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php - About 7 hrs to fix

    File class-wc-rest-coupons-v2-controller.php has 399 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * REST API Coupons controller
 *
 * Handles requests to the /coupons endpoint.
    Severity: Minor
    Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php - About 5 hrs to fix

      Function prepare_object_for_database has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function prepare_object_for_database( $request, $creating = false ) {
        $id        = isset( $request['id'] ) ? absint( $request['id'] ) : 0;
        $coupon    = new WC_Coupon( $id );
        $schema    = $this->get_item_schema();
        $data_keys = array_keys( array_filter( $schema['properties'], array( $this, 'filter_writable_props' ) ) );
      Severity: Minor
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method register_routes has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_routes() {
        register_rest_route(
            $this->namespace, '/' . $this->rest_base, array(
                array(
                    'methods'             => WP_REST_Server::READABLE,
      Severity: Major
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php - About 2 hrs to fix

        Method get_formatted_item_data has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function get_formatted_item_data( $object ) {
        $data = $object->get_data();

        $format_decimal = array( 'amount', 'minimum_amount', 'maximum_amount' );
        $format_date    = array( 'date_created', 'date_modified', 'date_expires' );
        Severity: Minor
        Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php - About 1 hr to fix

          Method prepare_object_for_database has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function prepare_object_for_database( $request, $creating = false ) {
        $id        = isset( $request['id'] ) ? absint( $request['id'] ) : 0;
        $coupon    = new WC_Coupon( $id );
        $schema    = $this->get_item_schema();
        $data_keys = array_keys( array_filter( $schema['properties'], array( $this, 'filter_writable_props' ) ) );
          Severity: Minor
          Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function register_routes() {
        register_rest_route(
            $this->namespace, '/' . $this->rest_base, array(
                array(
                    'methods'             => WP_REST_Server::READABLE,
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php and 1 other location - About 2 days to fix
            includes/rest-api/Controllers/Version1/class-wc-rest-coupons-v1-controller.php on lines 56..124

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 529.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ( $data_keys as $key ) {
            $value = $request[ $key ];

            if ( ! is_null( $value ) ) {
                switch ( $key ) {
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php and 1 other location - About 1 day to fix
            includes/legacy/api/class-wc-rest-legacy-coupons-controller.php on lines 118..151

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 258.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 13 locations. Consider refactoring.
            Open

                            'meta_data'                   => array(
                    'description' => __( 'Meta data.', 'woocommerce' ),
                    'type'        => 'array',
                    'context'     => array( 'view', 'edit' ),
                    'items'       => array(
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php and 12 other locations - About 4 hrs to fix
            includes/rest-api/Controllers/Version2/class-wc-rest-customers-v2-controller.php on lines 333..358
            includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 400..425
            includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1254..1279
            includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1472..1497
            includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1563..1588
            includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1661..1686
            includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1719..1744
            includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 965..990
            includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2240..2265
            includes/rest-api/Controllers/Version3/class-wc-rest-customers-controller.php on lines 276..301
            includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 724..749
            includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1303..1328

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 177.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status