Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version2/class-wc-rest-product-categories-v2-controller.php

Summary

Maintainability
F
1 wk
Test Coverage

Method get_item_schema has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => $this->taxonomy,
            'type'       => 'object',
Severity: Major
Found in includes/rest-api/Controllers/Version2/class-wc-rest-product-categories-v2-controller.php - About 4 hrs to fix

    Method prepare_item_for_response has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function prepare_item_for_response( $item, $request ) {
        // Get category display type.
        $display_type = get_term_meta( $item->term_id, 'display_type', true );

        // Get category order.
    Severity: Minor
    Found in includes/rest-api/Controllers/Version2/class-wc-rest-product-categories-v2-controller.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => $this->taxonomy,
            'type'       => 'object',
      Severity: Major
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-product-categories-v2-controller.php and 1 other location - About 4 days to fix
      includes/rest-api/Controllers/Version3/class-wc-rest-product-categories-controller.php on lines 96..211

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 805.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function prepare_item_for_response( $item, $request ) {
        // Get category display type.
        $display_type = get_term_meta( $item->term_id, 'display_type', true );

        // Get category order.
      Severity: Major
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-product-categories-v2-controller.php and 1 other location - About 2 days to fix
      includes/rest-api/Controllers/Version3/class-wc-rest-product-categories-controller.php on lines 35..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 421.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status