woothemes/woocommerce

View on GitHub
includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php

Summary

Maintainability
F
1 wk
Test Coverage

File class-wc-rest-product-variations-v2-controller.php has 753 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * REST API variations controller
 *
 * Handles requests to the /products/<product_id>/variations endpoints.

    Method get_item_schema has 347 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_item_schema() {
            $weight_unit    = get_option( 'woocommerce_weight_unit' );
            $dimension_unit = get_option( 'woocommerce_dimension_unit' );
            $schema         = array(
                '$schema'    => 'http://json-schema.org/draft-04/schema#',

      Function prepare_object_for_database has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function prepare_object_for_database( $request, $creating = false ) {
              if ( isset( $request['id'] ) ) {
                  $variation = wc_get_product( absint( $request['id'] ) );
              } else {
                  $variation = new WC_Product_Variation();

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method prepare_object_for_database has 135 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function prepare_object_for_database( $request, $creating = false ) {
              if ( isset( $request['id'] ) ) {
                  $variation = wc_get_product( absint( $request['id'] ) );
              } else {
                  $variation = new WC_Product_Variation();

        Method register_routes has 85 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function register_routes() {
                register_rest_route(
                    $this->namespace, '/' . $this->rest_base, array(
                        'args'   => array(
                            'product_id' => array(

          Method delete_item has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function delete_item( $request ) {
                  $force  = (bool) $request['force'];
                  $object = $this->get_object( (int) $request['id'] );
                  $result = false;
          
          

            Method prepare_object_for_response has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function prepare_object_for_response( $object, $request ) {
                    $data = array(
                        'id'                    => $object->get_id(),
                        'date_created'          => wc_rest_prepare_date_response( $object->get_date_created(), false ),
                        'date_created_gmt'      => wc_rest_prepare_date_response( $object->get_date_created() ),

              Function delete_item has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function delete_item( $request ) {
                      $force  = (bool) $request['force'];
                      $object = $this->get_object( (int) $request['id'] );
                      $result = false;
              
              

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return $response;

                Avoid too many return statements within this method.
                Open

                            return new WP_Error(
                                /* translators: %s: post type */
                                'woocommerce_rest_cannot_delete', sprintf( __( 'The %s cannot be deleted.', 'woocommerce' ), $this->post_type ), array(
                                    'status' => 500,
                                )

                  Function batch_items has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function batch_items( $request ) {
                          $items       = array_filter( $request->get_params() );
                          $params      = $request->get_url_params();
                          $query       = $request->get_query_params();
                          $product_id  = $params['product_id'];

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                      'properties'  => array(
                                          'id'                => array(
                                              'description' => __( 'Image ID.', 'woocommerce' ),
                                              'type'        => 'integer',
                                              'context'     => array( 'view', 'edit' ),
                  includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2094..2145

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 385.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          register_rest_route(
                              $this->namespace, '/' . $this->rest_base . '/(?P<id>[\d]+)', array(
                                  'args'   => array(
                                      'product_id' => array(
                                          'description' => __( 'Unique identifier for the variable product.', 'woocommerce' ),
                  includes/rest-api/Controllers/Version1/class-wc-rest-product-attribute-terms-v1-controller.php on lines 72..110
                  includes/rest-api/Controllers/Version1/class-wc-rest-product-reviews-v1-controller.php on lines 85..123

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 284.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 6 locations. Consider refactoring.
                  Open

                                  'dimensions'            => array(
                                      'description' => __( 'Variation dimensions.', 'woocommerce' ),
                                      'type'        => 'object',
                                      'context'     => array( 'view', 'edit' ),
                                      'properties'  => array(
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 1992..2016
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2445..2469
                  includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 1933..1957
                  includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 606..630
                  includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1000..1024

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 188.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if ( $force ) {
                              $object->delete( true );
                              $result = 0 === $object->get_id();
                          } else {
                              // If we don't support trashing for this type, error out.
                  includes/rest-api/Controllers/Version3/class-wc-rest-crud-controller.php on lines 443..463

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 180.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 13 locations. Consider refactoring.
                  Open

                                  'meta_data'             => array(
                                      'description' => __( 'Meta data.', 'woocommerce' ),
                                      'type'        => 'array',
                                      'context'     => array( 'view', 'edit' ),
                                      'items'       => array(
                  includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php on lines 494..519
                  includes/rest-api/Controllers/Version2/class-wc-rest-customers-v2-controller.php on lines 333..358
                  includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 400..425
                  includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1254..1279
                  includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1472..1497
                  includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1563..1588
                  includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1661..1686
                  includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1719..1744
                  includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2240..2265
                  includes/rest-api/Controllers/Version3/class-wc-rest-customers-controller.php on lines 276..301
                  includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 724..749
                  includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1303..1328

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 177.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                                  'attributes'            => array(
                                      'description' => __( 'List of attributes.', 'woocommerce' ),
                                      'type'        => 'array',
                                      'context'     => array( 'view', 'edit' ),
                                      'items'       => array(
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 1877..1901
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2237..2261
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2354..2378
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2526..2550
                  includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 751..775
                  includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 1825..1849
                  includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2193..2217
                  includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 514..538
                  includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 694..718
                  includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 891..915
                  includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1255..1279

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 169.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 12 locations. Consider refactoring.
                  Open

                                  'downloads'             => array(
                                      'description' => __( 'List of downloadable files.', 'woocommerce' ),
                                      'type'        => 'array',
                                      'context'     => array( 'view', 'edit' ),
                                      'items'       => array(
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 1877..1901
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2237..2261
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2354..2378
                  includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2526..2550
                  includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 935..959
                  includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 1825..1849
                  includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2193..2217
                  includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 514..538
                  includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 694..718
                  includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 891..915
                  includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1255..1279

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 169.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                          register_rest_route(
                              $this->namespace, '/' . $this->rest_base . '/batch', array(
                                  'args'   => array(
                                      'product_id' => array(
                                          'description' => __( 'Unique identifier for the variable product.', 'woocommerce' ),
                  includes/rest-api/Controllers/Version1/class-wc-rest-product-attribute-terms-v1-controller.php on lines 112..126
                  includes/rest-api/Controllers/Version2/class-wc-rest-product-reviews-v2-controller.php on lines 41..57
                  includes/rest-api/Controllers/Version2/class-wc-rest-setting-options-v2-controller.php on lines 58..74

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 123.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $links      = array(
                              'self'       => array(
                                  'href' => rest_url( sprintf( '/%s/%s/%d', $this->namespace, $base, $object->get_id() ) ),
                              ),
                              'collection' => array(
                  includes/rest-api/Controllers/Version1/class-wc-rest-order-refunds-v1-controller.php on lines 243..253

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 113.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          foreach ( array( 'update', 'create', 'delete' ) as $batch_type ) {
                              if ( ! empty( $items[ $batch_type ] ) ) {
                                  $injected_items = array();
                                  foreach ( $items[ $batch_type ] as $item ) {
                                      $injected_items[] = is_array( $item ) ? array_merge(
                  includes/rest-api/Controllers/Version2/class-wc-rest-product-reviews-v2-controller.php on lines 125..133

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 96.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status