Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php

Summary

Maintainability
F
5 days
Test Coverage

File class-wc-rest-shipping-zone-methods-v2-controller.php has 392 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * REST API Shipping Zone Methods controller
 *
 * Handles requests to the /shipping/zones/<id>/methods endpoint.
Severity: Minor
Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 5 hrs to fix

    Method get_item_schema has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function get_item_schema() {
        $schema = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
            'title'      => 'shipping_zone_method',
            'type'       => 'object',
    Severity: Major
    Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 4 hrs to fix

      Function update_fields has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          public function update_fields( $instance_id, $method, $request ) {
        global $wpdb;

        // Update settings if present.
        if ( isset( $request['settings'] ) ) {
      Severity: Minor
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method register_routes has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register_routes() {
        register_rest_route(
            $this->namespace, '/' . $this->rest_base . '/(?P<zone_id>[\d]+)/methods', array(
                'args'   => array(
                    'zone_id' => array(
      Severity: Major
      Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 2 hrs to fix

        Method update_fields has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function update_fields( $instance_id, $method, $request ) {
        global $wpdb;

        // Update settings if present.
        if ( isset( $request['settings'] ) ) {
        Severity: Minor
        Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 1 hr to fix

          Method delete_item has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function delete_item( $request ) {
        $zone = $this->get_zone( $request['zone_id'] );
        if ( is_wp_error( $zone ) ) {
            return $zone;
        }
          Severity: Minor
          Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 1 hr to fix

            Function delete_item has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function delete_item( $request ) {
        $zone = $this->get_zone( $request['zone_id'] );
        if ( is_wp_error( $zone ) ) {
            return $zone;
        }
            Severity: Minor
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function update_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function update_item( $request ) {
        $zone = $this->get_zone( $request['zone_id'] );
        if ( is_wp_error( $zone ) ) {
            return $zone;
        }
            Severity: Minor
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function create_item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function create_item( $request ) {
        $method_id = $request['method_id'];
        $zone      = $this->get_zone( $request['zone_id'] );
        if ( is_wp_error( $zone ) ) {
            return $zone;
            Severity: Minor
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return $response;
            Severity: Major
            Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 30 mins to fix

              Function get_item has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function get_item( $request ) {
        $zone = $this->get_zone( $request['zone_id'] );

        if ( is_wp_error( $zone ) ) {
            return $zone;
              Severity: Minor
              Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                              'settings'           => array(
                    'description' => __( 'Shipping method settings.', 'woocommerce' ),
                    'type'        => 'object',
                    'context'     => array( 'view', 'edit' ),
                    'properties'  => array(
              Severity: Major
              Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php and 2 other locations - About 2 days to fix
              includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php on lines 394..448
              includes/rest-api/Controllers/Version3/class-wc-rest-payment-gateways-controller.php on lines 166..220

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 443.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          foreach ( $method->get_instance_form_fields() as $key => $field ) {
                if ( isset( $request['settings'][ $key ] ) ) {
                    if ( is_callable( array( $this, 'validate_setting_' . $field['type'] . '_field' ) ) ) {
                        $value = $this->{'validate_setting_' . $field['type'] . '_field'}( $request['settings'][ $key ], $field );
                    } else {
              Severity: Major
              Found in includes/rest-api/Controllers/Version2/class-wc-rest-shipping-zone-methods-v2-controller.php and 1 other location - About 3 hrs to fix
              includes/rest-api/Controllers/Version2/class-wc-rest-payment-gateways-v2-controller.php on lines 171..184

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 146.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status