Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php

Summary

Maintainability
D
2 days
Test Coverage

Function prepare_object_for_database has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    protected function prepare_object_for_database( $request, $creating = false ) {
        $id        = isset( $request['id'] ) ? absint( $request['id'] ) : 0;
        $order     = new WC_Order( $id );
        $schema    = $this->get_item_schema();
        $data_keys = array_keys( array_filter( $schema['properties'], array( $this, 'filter_writable_props' ) ) );
Severity: Minor
Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function save_object has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    protected function save_object( $request, $creating = false ) {
        try {
            $object = $this->prepare_object_for_database( $request, $creating );

            if ( is_wp_error( $object ) ) {
Severity: Minor
Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function calculate_coupons has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function calculate_coupons( $request, $order ) {
        if ( ! isset( $request['coupon_lines'] ) || ! is_array( $request['coupon_lines'] ) ) {
            return false;
        }
Severity: Minor
Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method prepare_object_for_database has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function prepare_object_for_database( $request, $creating = false ) {
        $id        = isset( $request['id'] ) ? absint( $request['id'] ) : 0;
        $order     = new WC_Order( $id );
        $schema    = $this->get_item_schema();
        $data_keys = array_keys( array_filter( $schema['properties'], array( $this, 'filter_writable_props' ) ) );
Severity: Minor
Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php - About 1 hr to fix

    Method save_object has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function save_object( $request, $creating = false ) {
        try {
            $object = $this->prepare_object_for_database( $request, $creating );

            if ( is_wp_error( $object ) ) {
    Severity: Minor
    Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                      if ( isset( $request['billing'] ) || isset( $request['shipping'] ) || isset( $request['line_items'] ) || isset( $request['shipping_lines'] ) || isset( $request['fee_lines'] ) || isset( $request['coupon_lines'] ) ) {
                    $object->calculate_totals( true );
                }
      Severity: Major
      Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php - About 40 mins to fix

        Function prepare_objects_query has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function prepare_objects_query( $request ) {
        // This is needed to get around an array to string notice in WC_REST_Orders_V2_Controller::prepare_objects_query.
        $statuses = $request['status'];
        unset( $request['status'] );
        $args = parent::prepare_objects_query( $request );
        Severity: Minor
        Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if ( ! is_null( $request['customer_id'] ) && 0 !== $request['customer_id'] ) {
                // Make sure customer exists.
                if ( false === get_user_by( 'id', $request['customer_id'] ) ) {
                    throw new WC_REST_Exception( 'woocommerce_rest_invalid_customer_id', __( 'Customer ID is invalid.', 'woocommerce' ), 400 );
                }
        Severity: Major
        Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php and 1 other location - About 2 hrs to fix
        includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 630..640

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if ( $creating ) {
                $object->set_created_via( 'rest-api' );
                $object->set_prices_include_tax( 'yes' === get_option( 'woocommerce_prices_include_tax' ) );
                $object->calculate_totals();
            } else {
        Severity: Major
        Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php and 1 other location - About 1 hr to fix
        includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 642..651

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                            case 'fee_lines':
                        if ( is_array( $value ) ) {
                            foreach ( $value as $item ) {
                                if ( is_array( $item ) ) {
                                    if ( $this->item_is_null( $item ) || ( isset( $item['quantity'] ) && 0 === $item['quantity'] ) ) {
        Severity: Major
        Found in includes/rest-api/Controllers/Version3/class-wc-rest-orders-controller.php and 3 other locations - About 55 mins to fix
        includes/legacy/api/class-wc-rest-legacy-orders-controller.php on lines 184..196
        includes/rest-api/Controllers/Version1/class-wc-rest-orders-v1-controller.php on lines 471..483
        includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 568..580

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status