Sign upLogin

woothemes/woocommerce

View on GitHub
Star
includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php

Summary

Maintainability
F
1 wk
Test Coverage

Method get_item_schema has 344 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function get_item_schema() {
        $weight_unit    = get_option( 'woocommerce_weight_unit' );
        $dimension_unit = get_option( 'woocommerce_dimension_unit' );
        $schema         = array(
            '$schema'    => 'http://json-schema.org/draft-04/schema#',
Severity: Major
Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 1 day to fix

    File class-wc-rest-product-variations-controller.php has 669 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * REST API variations controller
 *
 * Handles requests to the /products/<product_id>/variations endpoints.
    Severity: Major
    Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 1 day to fix

      Function prepare_object_for_database has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function prepare_object_for_database( $request, $creating = false ) {
        if ( isset( $request['id'] ) ) {
            $variation = wc_get_product( absint( $request['id'] ) );
        } else {
            $variation = new WC_Product_Variation();
      Severity: Minor
      Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method prepare_object_for_database has 131 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function prepare_object_for_database( $request, $creating = false ) {
        if ( isset( $request['id'] ) ) {
            $variation = wc_get_product( absint( $request['id'] ) );
        } else {
            $variation = new WC_Product_Variation();
      Severity: Major
      Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 5 hrs to fix

        Method prepare_object_for_response has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function prepare_object_for_response( $object, $request ) {
        $data = array(
            'id'                    => $object->get_id(),
            'date_created'          => wc_rest_prepare_date_response( $object->get_date_created(), false ),
            'date_created_gmt'      => wc_rest_prepare_date_response( $object->get_date_created() ),
        Severity: Major
        Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 2 hrs to fix

          Method prepare_objects_query has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function prepare_objects_query( $request ) {
        $args = WC_REST_CRUD_Controller::prepare_objects_query( $request );

        // Set post_status.
        $args['post_status'] = $request['status'];
          Severity: Minor
          Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 2 hrs to fix

            Function set_variation_image has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function set_variation_image( $variation, $image ) {
        $attachment_id = isset( $image['id'] ) ? absint( $image['id'] ) : 0;

        if ( 0 === $attachment_id ) {
            if ( isset( $image['src'] ) ) {
            Severity: Minor
            Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method set_variation_image has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function set_variation_image( $variation, $image ) {
        $attachment_id = isset( $image['id'] ) ? absint( $image['id'] ) : 0;

        if ( 0 === $attachment_id ) {
            if ( isset( $image['src'] ) ) {
            Severity: Minor
            Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 1 hr to fix

              Function prepare_objects_query has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function prepare_objects_query( $request ) {
        $args = WC_REST_CRUD_Controller::prepare_objects_query( $request );

        // Set post_status.
        $args['post_status'] = $request['status'];
              Severity: Minor
              Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                              'dimensions'            => array(
                    'description' => __( 'Variation dimensions.', 'woocommerce' ),
                    'type'        => 'object',
                    'context'     => array( 'view', 'edit' ),
                    'properties'  => array(
              Severity: Major
              Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php and 5 other locations - About 5 hrs to fix
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 1992..2016
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2445..2469
              includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 842..866
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 1933..1957
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1000..1024

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 188.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 13 locations. Consider refactoring.
              Open

                              'meta_data'             => array(
                    'description' => __( 'Meta data.', 'woocommerce' ),
                    'type'        => 'array',
                    'context'     => array( 'view', 'edit' ),
                    'items'       => array(
              Severity: Major
              Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php and 12 other locations - About 4 hrs to fix
              includes/rest-api/Controllers/Version2/class-wc-rest-coupons-v2-controller.php on lines 494..519
              includes/rest-api/Controllers/Version2/class-wc-rest-customers-v2-controller.php on lines 333..358
              includes/rest-api/Controllers/Version2/class-wc-rest-order-refunds-v2-controller.php on lines 400..425
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1254..1279
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1472..1497
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1563..1588
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1661..1686
              includes/rest-api/Controllers/Version2/class-wc-rest-orders-v2-controller.php on lines 1719..1744
              includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 965..990
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2240..2265
              includes/rest-api/Controllers/Version3/class-wc-rest-customers-controller.php on lines 276..301
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1303..1328

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 177.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 12 locations. Consider refactoring.
              Open

                              'attributes'            => array(
                    'description' => __( 'List of attributes.', 'woocommerce' ),
                    'type'        => 'array',
                    'context'     => array( 'view', 'edit' ),
                    'items'       => array(
              Severity: Major
              Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php and 11 other locations - About 4 hrs to fix
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 1877..1901
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2237..2261
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2354..2378
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2526..2550
              includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 751..775
              includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 935..959
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 1825..1849
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2193..2217
              includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 514..538
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 891..915
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1255..1279

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 169.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 12 locations. Consider refactoring.
              Open

                              'downloads'             => array(
                    'description' => __( 'List of downloadable files.', 'woocommerce' ),
                    'type'        => 'array',
                    'context'     => array( 'view', 'edit' ),
                    'items'       => array(
              Severity: Major
              Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php and 11 other locations - About 4 hrs to fix
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 1877..1901
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2237..2261
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2354..2378
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 2526..2550
              includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 751..775
              includes/rest-api/Controllers/Version2/class-wc-rest-product-variations-v2-controller.php on lines 935..959
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 1825..1849
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 2193..2217
              includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php on lines 694..718
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 891..915
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 1255..1279

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 169.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          return array(
                'id'                => (int) $attachment_id,
                'date_created'      => wc_rest_prepare_date_response( $attachment_post->post_date, false ),
                'date_created_gmt'  => wc_rest_prepare_date_response( strtotime( $attachment_post->post_date_gmt ) ),
                'date_modified'     => wc_rest_prepare_date_response( $attachment_post->post_modified, false ),
              Severity: Major
              Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php and 1 other location - About 2 hrs to fix
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 58..67

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 137.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 5 locations. Consider refactoring.
              Open

                      if ( ! empty( $request['sku'] ) ) {
            $skus = explode( ',', $request['sku'] );
            // Include the current string as a SKU too.
            if ( 1 < count( $skus ) ) {
                $skus[] = $request['sku'];
              Severity: Major
              Found in includes/rest-api/Controllers/Version3/class-wc-rest-product-variations-controller.php and 4 other locations - About 55 mins to fix
              includes/legacy/api/class-wc-rest-legacy-products-controller.php on lines 102..114
              includes/rest-api/Controllers/Version1/class-wc-rest-products-v1-controller.php on lines 192..204
              includes/rest-api/Controllers/Version2/class-wc-rest-products-v2-controller.php on lines 264..279
              includes/rest-api/Controllers/Version3/class-wc-rest-products-controller.php on lines 148..163

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status