workcraft/workcraft

View on GitHub
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java

Summary

Maintainability
B
6 hrs
Test Coverage

Avoid too many return statements within this method.
Open

                return false;

    Avoid too many return statements within this method.
    Open

                return false;

      Avoid too many return statements within this method.
      Open

              return true;

        Avoid too many return statements within this method.
        Open

                    return false;

          Avoid too many return statements within this method.
          Open

                          return false;

            Avoid too many return statements within this method.
            Open

                            return false;

              Avoid too many return statements within this method.
              Open

                          return false;

                Avoid too many return statements within this method.
                Open

                                return false;

                  Identical blocks of code found in 8 locations. Consider refactoring.
                  Open

                          if (ports == null) {
                              if (other.ports != null) {
                                  return false;
                              }
                          } else if (!ports.equals(other.ports)) {
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 88..94
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 102..108
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 109..115
                  workcraft/WorkcraftCore/src/org/workcraft/types/Pair.java on lines 41..47
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 46..52
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 53..59
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 60..66

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 8 locations. Consider refactoring.
                  Open

                          if (rectangles == null) {
                              if (other.rectangles != null) {
                                  return false;
                              }
                          } else if (!rectangles.equals(other.rectangles)) {
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 88..94
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 95..101
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 109..115
                  workcraft/WorkcraftCore/src/org/workcraft/types/Pair.java on lines 41..47
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 46..52
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 53..59
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 60..66

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 8 locations. Consider refactoring.
                  Open

                          if (segments == null) {
                              if (other.segments != null) {
                                  return false;
                              }
                          } else if (!segments.equals(other.segments)) {
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 88..94
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 95..101
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 102..108
                  workcraft/WorkcraftCore/src/org/workcraft/types/Pair.java on lines 41..47
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 46..52
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 53..59
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 60..66

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 8 locations. Consider refactoring.
                  Open

                          if (connections == null) {
                              if (other.connections != null) {
                                  return false;
                              }
                          } else if (!connections.equals(other.connections)) {
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 95..101
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 102..108
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/routing/impl/RouterTask.java on lines 109..115
                  workcraft/WorkcraftCore/src/org/workcraft/types/Pair.java on lines 41..47
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 46..52
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 53..59
                  workcraft/WorkcraftCore/src/org/workcraft/types/Triple.java on lines 60..66

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 44.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status