workcraft/workcraft

View on GitHub
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java

Summary

Maintainability
D
1 day
Test Coverage

Avoid too many return statements within this method.
Open

                    return Result.failure(new VerificationChainOutput(
                            devExportResult, pcompResult, unfoldingResult, preparationParameters));

    Avoid too many return statements within this method.
    Open

                            return Result.success(new VerificationChainOutput(
                                    devExportResult, pcompResult, persistencyMpsatResult, persistencyParameters,
                                    "Circuit is not output-persistent after the following trace(s):"));

      Avoid too many return statements within this method.
      Open

                              return Result.failure(new VerificationChainOutput(
                                      devExportResult, pcompResult, null, preparationParameters));

        Avoid too many return statements within this method.
        Open

                            return Result.exception(e);

          Avoid too many return statements within this method.
          Open

                      return Result.success(new VerificationChainOutput(
                              devExportResult, pcompResult, mpsatResult, completionParameters, message));

            Avoid too many return statements within this method.
            Open

                                    return Result.failure(new VerificationChainOutput(
                                            devExportResult, pcompResult, deadlockMpsatResult, deadlockParameters));

              Avoid too many return statements within this method.
              Open

                                  return Result.failure(new VerificationChainOutput(
                                          devExportResult, modPcompResult, null, preparationParameters));

                Avoid too many return statements within this method.
                Open

                                            return Result.cancel();

                  Avoid too many return statements within this method.
                  Open

                                          return Result.cancel();

                    Avoid too many return statements within this method.
                    Open

                                        return Result.failure(new VerificationChainOutput(
                                                compositionExportResult, modPcompResult, conformationMpsatResult, conformationParameters));

                      Avoid too many return statements within this method.
                      Open

                                              return Result.success(new VerificationChainOutput(
                                                      devExportResult, pcompResult, deadlockMpsatResult, deadlockParameters,
                                                      "Circuit has a deadlock after the following trace(s):"));

                        Avoid too many return statements within this method.
                        Open

                                                    return Result.cancel();

                          Avoid too many return statements within this method.
                          Open

                                      return new Result<>(e);

                            Avoid too many return statements within this method.
                            Open

                                                        return Result.cancel();

                              Avoid too many return statements within this method.
                              Open

                                                  return Result.success(new VerificationChainOutput(
                                                          compositionExportResult, modPcompResult, conformationMpsatResult, conformationParameters,
                                                          "Circuit does not conform to the environment after the following trace(s):"));

                                Avoid too many return statements within this method.
                                Open

                                                    return Result.failure(new VerificationChainOutput(
                                                            modEnvExportResult, null, null, preparationParameters));

                                  Avoid too many return statements within this method.
                                  Open

                                                          return Result.cancel();

                                    Avoid too many return statements within this method.
                                    Open

                                                            return Result.cancel();

                                      Avoid too many return statements within this method.
                                      Open

                                                              return Result.cancel();

                                        Avoid too many return statements within this method.
                                        Open

                                                                return Result.failure(new VerificationChainOutput(
                                                                        devExportResult, pcompResult, persistencyMpsatResult, persistencyParameters));

                                          Identical blocks of code found in 6 locations. Consider refactoring.
                                          Open

                                                          if (!conformationMpsatResult.isSuccess()) {
                                                              if (conformationMpsatResult.isCancel()) {
                                                                  return Result.cancel();
                                                              }
                                                              return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 109..115
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 224..230
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 240..246
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 270..276
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java on lines 140..145

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                                              if (!pcompResult.isSuccess()) {
                                                                  if (pcompResult.isCancel()) {
                                                                      return Result.cancel();
                                                                  }
                                                                  return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 92..98
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 126..132

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 10 locations. Consider refactoring.
                                          Open

                                                          if (!envExportResult.isSuccess()) {
                                                              if (envExportResult.isCancel()) {
                                                                  return Result.cancel();
                                                              }
                                                              return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 65..71
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 82..88
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 96..102
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 112..118
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 99..105
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 55..61
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/DeadlockFreenessCheckTask.java on lines 58..64
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 55..61
                                          workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/tasks/DeadlockFreenessTask.java on lines 54..60

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 10 locations. Consider refactoring.
                                          Open

                                                      if (!devExportResult.isSuccess()) {
                                                          if (devExportResult.isCancel()) {
                                                              return Result.cancel();
                                                          }
                                                          return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 65..71
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 82..88
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 83..89
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 112..118
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 99..105
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 55..61
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/DeadlockFreenessCheckTask.java on lines 58..64
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 55..61
                                          workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/tasks/DeadlockFreenessTask.java on lines 54..60

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 6 locations. Consider refactoring.
                                          Open

                                                              if (!deadlockMpsatResult.isSuccess()) {
                                                                  if (deadlockMpsatResult.isCancel()) {
                                                                      return Result.cancel();
                                                                  }
                                                                  return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 109..115
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 175..181
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 224..230
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 270..276
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java on lines 140..145

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 10 locations. Consider refactoring.
                                          Open

                                                          if (!modEnvExportResult.isSuccess()) {
                                                              if (modEnvExportResult.isCancel()) {
                                                                  return Result.cancel();
                                                              }
                                                              return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 65..71
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 82..88
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 83..89
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 96..102
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 99..105
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 55..61
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/DeadlockFreenessCheckTask.java on lines 58..64
                                          workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 55..61
                                          workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/tasks/DeadlockFreenessTask.java on lines 54..60

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 6 locations. Consider refactoring.
                                          Open

                                                          if (!unfoldingResult.isSuccess()) {
                                                              if (unfoldingResult.isCancel()) {
                                                                  return Result.cancel();
                                                              }
                                                              return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 109..115
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 175..181
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 240..246
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 270..276
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java on lines 140..145

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 6 locations. Consider refactoring.
                                          Open

                                                              if (!persistencyMpsatResult.isSuccess()) {
                                                                  if (persistencyMpsatResult.isCancel()) {
                                                                      return Result.cancel();
                                                                  }
                                                                  return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 109..115
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 175..181
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 224..230
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 240..246
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java on lines 140..145

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Identical blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                                          if (!modPcompResult.isSuccess()) {
                                                              if (modPcompResult.isCancel()) {
                                                                  return Result.cancel();
                                                              }
                                                              return Result.failure(new VerificationChainOutput(
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 92..98
                                          workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 201..207

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 40.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          There are no issues that match your filters.

                                          Category
                                          Status