workcraft/workcraft

View on GitHub
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java

Summary

Maintainability
B
6 hrs
Test Coverage

Avoid too many return statements within this method.
Open

                    return Result.cancel();

    Avoid too many return statements within this method.
    Open

                    return Result.failure(new SpotChainOutput(ltl2tgbaResult, devExportResult, pcompResult, mpsatResult));

      Avoid too many return statements within this method.
      Open

                  return Result.success(new SpotChainOutput(ltl2tgbaResult, devExportResult, pcompResult, mpsatResult));

        Avoid too many return statements within this method.
        Open

                            return Result.failure(new SpotChainOutput(ltl2tgbaResult, envExportResult, null, null));

          Avoid too many return statements within this method.
          Open

                              return Result.failure(new SpotChainOutput(ltl2tgbaResult, envExportResult, pcompResult, null));

            Avoid too many return statements within this method.
            Open

                                    return Result.cancel();

              Avoid too many return statements within this method.
              Open

                                      return Result.cancel();

                Avoid too many return statements within this method.
                Open

                            return new Result<>(e);

                  Avoid too many return statements within this method.
                  Open

                                  return Result.failure(new SpotChainOutput(ltl2tgbaResult, devExportResult, null, null));

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                if (envStg != null) {
                                    // Make sure that input signals of the device STG are also inputs in the environment STG
                                    Set<String> inputSignalNames = devStg.getSignalNames(Signal.Type.INPUT, null);
                                    Set<String> outputSignalNames = devStg.getSignalNames(Signal.Type.OUTPUT, null);
                                    StgUtils.restoreInterfaceSignals(envStg, inputSignalNames, outputSignalNames);
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 54..59
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CombinedCheckTask.java on lines 61..66

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 6 locations. Consider refactoring.
                    Open

                                if (!mpsatResult.isSuccess()) {
                                    if (mpsatResult.isCancel()) {
                                        return Result.cancel();
                                    }
                                    return Result.failure(new SpotChainOutput(ltl2tgbaResult, devExportResult, pcompResult, mpsatResult));
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 109..115
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 175..181
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 224..230
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 240..246
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 270..276

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (!devExportResult.isSuccess()) {
                                    if (devExportResult.isCancel()) {
                                        return Result.cancel();
                                    }
                                    return Result.failure(new SpotChainOutput(ltl2tgbaResult, devExportResult, null, null));
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java on lines 107..112

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    if (!envExportResult.isSuccess()) {
                                        if (envExportResult.isCancel()) {
                                            return Result.cancel();
                                        }
                                        return Result.failure(new SpotChainOutput(ltl2tgbaResult, envExportResult, null, null));
                    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/SpotChainTask.java on lines 91..96

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status