Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java

Summary

Maintainability
A
3 hrs
Test Coverage

Avoid too many return statements within this method.
Open

            return Result.success(new VerificationChainOutput(
                    envExportResult, null, mpsatResult, verificationParameters,
                    "The circuit strictly implements its environment."));
Severity: Major
Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return Result.success(new VerificationChainOutput(
                        envExportResult, null, mpsatResult, verificationParameters,
                        "Circuit does not strictly implement the environment after the following trace(s):"));
    Severity: Major
    Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return new Result<>(e);
      Severity: Major
      Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java - About 30 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            private class SignalInfo {
        public final String name;
        public final String setExpr;
        public final String resetExpr;
        Severity: Major
        Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java and 3 other locations - About 40 mins to fix
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/CircuitSignalInfo.java on lines 30..40
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/commands/BinateImplementationVerificationCommand.java on lines 32..42
        workcraft/WorkcraftCore/src/org/workcraft/utils/HighlightUtils.java on lines 13..23

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 10 locations. Consider refactoring.
        Open

                    if (!envExportResult.isSuccess()) {
                if (envExportResult.isCancel()) {
                    return Result.cancel();
                }
                return Result.failure(new VerificationChainOutput(
        Severity: Major
        Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java and 9 other locations - About 30 mins to fix
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 65..71
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 82..88
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 83..89
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 96..102
        workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 112..118
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 55..61
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/DeadlockFreenessCheckTask.java on lines 58..64
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 55..61
        workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/tasks/DeadlockFreenessTask.java on lines 54..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

                    if (!mpsatResult.isSuccess()) {
                if (mpsatResult.isCancel()) {
                    return Result.cancel();
                }
                return Result.failure(new VerificationChainOutput(
        Severity: Major
        Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java and 4 other locations - About 30 mins to fix
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 69..75
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 83..89
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 103..109
        workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 68..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status