Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java

Summary

Maintainability
B
6 hrs
Test Coverage

Method getOrCreateContact has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private static VisualContact getOrCreateContact(VisualCircuit circuit, VisualFunctionComponent component,
            String contactName, Contact.IOType ioType, VisualContact.Direction direction, Point2D offset) {
Severity: Minor
Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java - About 45 mins to fix

    Method connectFromIndividualInputPort has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private static VisualConnection connectFromIndividualInputPort(VisualCircuit circuit, String portPrefix,
            int index, VisualContact pin, boolean initToOne) {
    Severity: Minor
    Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java - About 35 mins to fix

      Method connectCommonInputPort has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static void connectCommonInputPort(VisualCircuit circuit, List<VisualFunctionComponent> components,
            String portName, String pinName, boolean initToOne) {
      Severity: Minor
      Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java - About 35 mins to fix

        Method connectIndividualScanPathbreaker has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private static int connectIndividualScanPathbreaker(VisualCircuit circuit, VisualFunctionComponent component,
            ScanData scanData, int index, boolean needScaninInversion) {
        Severity: Minor
        Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                  return getAdjacentBufferOrInverter(circuit, drivenContact);
          Severity: Major
          Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private static List<VisualContact> getSortedOutputPinsByPrefix(VisualFunctionComponent component, String prefix) {
        return component.getVisualContacts().stream()
                .filter(contact -> contact.isOutput() && contact.getName().startsWith(prefix))
                .sorted((c1, c2) -> SortUtils.compareNatural(c1, c2, VisualContact::getName))
                .collect(Collectors.toList());
            Severity: Minor
            Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java and 1 other location - About 45 mins to fix
            workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java on lines 375..380

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private static List<VisualContact> getSortedInputPinsByPrefix(VisualFunctionComponent component, String prefix) {
        return component.getVisualContacts().stream()
                .filter(contact -> contact.isInput() && contact.getName().startsWith(prefix))
                .sorted((c1, c2) -> SortUtils.compareNatural(c1, c2, VisualContact::getName))
                .collect(Collectors.toList());
            Severity: Minor
            Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java and 1 other location - About 45 mins to fix
            workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java on lines 382..387

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private static boolean hasContactWithPrefix(VisualCircuitComponent component, String prefix) {
        if ((prefix != null) && !prefix.isEmpty()) {
            return component.getVisualContacts().stream()
                    .anyMatch(contact -> contact.getName().startsWith(prefix));
        }
            Severity: Minor
            Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java and 1 other location - About 40 mins to fix
            workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java on lines 221..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private static boolean hasContactWithName(VisualCircuitComponent component, String name) {
        if ((name != null) && !name.isEmpty()) {
            return component.getVisualContacts().stream()
                    .anyMatch(contact -> contact.getName().equals(name));
        }
            Severity: Minor
            Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java and 1 other location - About 40 mins to fix
            workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/utils/ScanUtils.java on lines 138..144

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status