Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private void testStatisticsCommand(String workName, String expectedBasicStatistics, String expectedAdvancedStatistics)
            throws DeserialisationException {
        final Framework framework = Framework.getInstance();
        final ClassLoader classLoader = ClassLoader.getSystemClassLoader();
        URL url = classLoader.getResource(workName);
Severity: Major
Found in workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java and 2 other locations - About 1 hr to fix
workcraft/PetriPlugin/test-src/org/workcraft/plugins/petri/StatisticsCommandTests.java on lines 52..69
workcraft/StgPlugin/test-src/org/workcraft/plugins/stg/StatisticsCommandTests.java on lines 134..151

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    void testCelementDecomposedTmStatisticsCommand() throws DeserialisationException {
        String workName = PackageUtils.getPackagePath(getClass(), "celement-decomposed-tm.circuit.work");
        testStatisticsCommand(workName,
                "Component count:"
Severity: Major
Found in workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java and 2 other locations - About 1 hr to fix
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java on lines 25..46
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java on lines 71..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    void testVmeTmStatisticsCommand() throws DeserialisationException {
        String workName = PackageUtils.getPackagePath(getClass(), "vme-tm.circuit.work");
        testStatisticsCommand(workName,
                "Component count:"
Severity: Major
Found in workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java and 2 other locations - About 1 hr to fix
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java on lines 25..46
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java on lines 48..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Test
    void testBufferTmStatisticsCommand() throws DeserialisationException {
        String workName = PackageUtils.getPackagePath(getClass(), "buffer-tm.circuit.work");
        testStatisticsCommand(workName,
                "Component count:"
Severity: Major
Found in workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java and 2 other locations - About 1 hr to fix
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java on lines 48..69
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/StatisticsCommandTests.java on lines 71..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status