workcraft/workcraft

View on GitHub
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java

Summary

Maintainability
B
6 hrs
Test Coverage

Avoid too many return statements within this method.
Open

                    return Result.cancel();
Severity: Major
Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return Result.cancel();
    Severity: Major
    Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return Result.failure(new VerificationChainOutput(
                              exportResult, null, deadlockResult, deadlockParameters));
      Severity: Major
      Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return Result.failure(new VerificationChainOutput(
                                exportResult, null, persistencyResult, persistencyParameters));
        Severity: Major
        Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return Result.success(new VerificationChainOutput(
                                  exportResult, null, persistencyResult, persistencyParameters,
                                  "Dataflow is not output-persistent"));
          Severity: Major
          Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return Result.success(new VerificationChainOutput(
                                    exportResult, null, deadlockResult, deadlockParameters,
                                    "Dataflow has a deadlock"));
            Severity: Major
            Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return Result.success(new VerificationChainOutput(
                                  exportResult, null, null, completionParameters,
                                  "Dataflow is deadlock-free and output-persistent"));
              Severity: Major
              Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return new Result<>(e);
                Severity: Major
                Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java - About 30 mins to fix

                  Identical blocks of code found in 10 locations. Consider refactoring.
                  Open

                              if (!exportResult.isSuccess()) {
                                  if (exportResult.isCancel()) {
                                      return Result.cancel();
                                  }
                                  return Result.failure(new VerificationChainOutput(
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 65..71
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/AssertionCheckTask.java on lines 82..88
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 83..89
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 96..102
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckTask.java on lines 112..118
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 99..105
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/DeadlockFreenessCheckTask.java on lines 58..64
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 55..61
                  workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/tasks/DeadlockFreenessTask.java on lines 54..60

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                              if (!persistencyResult.isSuccess()) {
                                  if (persistencyResult.isCancel()) {
                                      return Result.cancel();
                                  }
                                  return Result.failure(new VerificationChainOutput(
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 128..134
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 69..75
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 83..89
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 68..74

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                              if (!deadlockResult.isSuccess()) {
                                  if (deadlockResult.isCancel()) {
                                      return Result.cancel();
                                  }
                                  return Result.failure(new VerificationChainOutput(
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 128..134
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 69..75
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 103..109
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 68..74

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 5 locations. Consider refactoring.
                  Open

                              if (!unfoldingResult.isSuccess()) {
                                  if (unfoldingResult.isCancel()) {
                                      return Result.cancel();
                                  }
                                  return Result.failure(new VerificationChainOutput(
                  workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/StrictImplementationCheckTask.java on lines 128..134
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 83..89
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/CheckTask.java on lines 103..109
                  workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tasks/OutputPersistencyCheckTask.java on lines 68..74

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status