Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/VisualSignal.java

Summary

Maintainability
A
1 hr
Test Coverage

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/VisualSignal.java - About 30 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        @Override
    public Rectangle2D getBoundingBoxInLocalSpace() {
        Rectangle2D bb = super.getBoundingBoxInLocalSpace();
        Collection<Touchable> touchableChildren = Hierarchy.getChildrenOfType(this, Touchable.class);
        Rectangle2D childrenBB = BoundingBoxHelper.mergeBoundingBoxes(touchableChildren);
    Severity: Minor
    Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/VisualSignal.java and 1 other location - About 40 mins to fix
    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/VisualCircuitComponent.java on lines 606..612

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        public Collection<VisualTransitionEvent> getVisualTransitions() {
        HashSet<VisualTransitionEvent> result = new HashSet<>();
        for (Node node: getChildren()) {
            if (node instanceof VisualTransitionEvent) {
                result.add((VisualTransitionEvent) node);
    Severity: Major
    Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/VisualSignal.java and 7 other locations - About 35 mins to fix
    workcraft/SonPlugin/src/org/workcraft/plugins/son/ONGroup.java on lines 70..79
    workcraft/SonPlugin/src/org/workcraft/plugins/son/ONGroup.java on lines 81..90
    workcraft/SonPlugin/src/org/workcraft/plugins/son/SON.java on lines 105..114
    workcraft/SonPlugin/src/org/workcraft/plugins/son/SON.java on lines 120..129
    workcraft/SonPlugin/src/org/workcraft/plugins/son/SON.java on lines 131..140
    workcraft/SonPlugin/src/org/workcraft/plugins/son/SON.java on lines 142..151
    workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualXmasComponent.java on lines 126..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status