Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static boolean isLevelConnection(MathConnection connection) {
        boolean result = false;
        if (connection != null) {
            MathNode c1 = connection.getFirst();
            MathNode c2 = connection.getSecond();
Severity: Major
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 1 other location - About 1 hr to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 113..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static boolean isEventConnection(MathConnection connection) {
        boolean result = false;
        if (connection != null) {
            MathNode c1 = connection.getFirst();
            MathNode c2 = connection.getSecond();
Severity: Major
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 1 other location - About 1 hr to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 99..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public static TransitionEvent.Direction getPreviousDirection(Signal.State state) {
        switch (state) {
        case HIGH:
            return TransitionEvent.Direction.RISE;
        case LOW:
Severity: Major
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 3 other locations - About 50 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 27..40
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 57..70
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 72..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public static Signal.State getNextState(TransitionEvent.Direction direction) {
        switch (direction) {
        case RISE:
            return Signal.State.HIGH;
        case FALL:
Severity: Major
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 3 other locations - About 50 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 27..40
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 42..55
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 72..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public static Signal.State getPreviousState(TransitionEvent.Direction direction) {
        switch (direction) {
        case RISE:
            return Signal.State.LOW;
        case FALL:
Severity: Major
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 3 other locations - About 50 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 27..40
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 42..55
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 57..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public static TransitionEvent.Direction getNextDirection(Signal.State state) {
        switch (state) {
        case HIGH:
            return TransitionEvent.Direction.FALL;
        case LOW:
Severity: Major
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 3 other locations - About 50 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 42..55
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 57..70
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 72..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static VisualEvent getPrevVisualEvent(VisualDtd dtd, VisualEvent event) {
        VisualLevelConnection prevLevel = getPrevVisualLevel(dtd, event);
        if (prevLevel != null) {
            Node first = prevLevel.getFirst();
            if (first instanceof VisualEvent) {
Severity: Minor
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 1 other location - About 45 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 205..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static VisualEvent getNextVisualEvent(VisualDtd dtd, VisualEvent event) {
        VisualLevelConnection nextLevel = getNextVisualLevel(dtd, event);
        if (nextLevel != null) {
            Node second = nextLevel.getSecond();
            if (second instanceof VisualEvent) {
Severity: Minor
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 1 other location - About 45 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 194..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static Color getTypeColor(Signal.Type type) {
        if (type != null) {
            switch (type) {
            case INPUT:
                return SignalCommonSettings.getInputColor();
Severity: Minor
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 1 other location - About 45 mins to fix
workcraft/StgPlugin/src/org/workcraft/plugins/stg/utils/StgUtils.java on lines 437..449

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static VisualLevelConnection getPrevVisualLevel(VisualDtd dtd, VisualEvent event) {
        for (Connection eventConnection : dtd.getConnections(event)) {
            if ((eventConnection instanceof VisualLevelConnection) && (eventConnection.getSecond() == event)) {
                return (VisualLevelConnection) eventConnection;
            }
Severity: Minor
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 1 other location - About 40 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 185..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static VisualLevelConnection getNextVisualLevel(VisualDtd dtd, VisualEvent event) {
        for (Connection eventConnection : dtd.getConnections(event)) {
            if ((eventConnection instanceof VisualLevelConnection) && (eventConnection.getFirst() == event)) {
                return (VisualLevelConnection) eventConnection;
            }
Severity: Minor
Found in workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java and 1 other location - About 40 mins to fix
workcraft/DtdPlugin/src/org/workcraft/plugins/dtd/utils/DtdUtils.java on lines 176..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status