Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/observers/SymbolConsistencySupervisor.java

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    private void handleEventRemoval(Event event) {
        Symbol symbol = event.getSymbol();
        if (symbol != null) {
            boolean symbolIsUnused = true;
            for (Event e: fsm.getEvents()) {
Severity: Major
Found in workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/observers/SymbolConsistencySupervisor.java and 3 other locations - About 1 hr to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/observers/SymbolConsistencySupervisor.java on lines 51..65
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/observers/SymbolConsistencySupervisor.java on lines 95..109
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/observers/SymbolConsistencySupervisor.java on lines 116..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 92.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void handleEvent(StateEvent e) {
        if (e instanceof PropertyChangedEvent) {
            PropertyChangedEvent pce = (PropertyChangedEvent) e;
            Object sender = e.getSender();
Severity: Minor
Found in workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/observers/SymbolConsistencySupervisor.java and 1 other location - About 50 mins to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/observers/SymbolConsistencySupervisor.java on lines 18..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    private void handleEventSymbolChange() {
        HashSet<Symbol> unusedSymbols = new HashSet<>(fsm.getSymbols());
        for (Event e: fsm.getEvents()) {
            Symbol symbol = e.getSymbol();
            unusedSymbols.remove(symbol);
Severity: Major
Found in workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/observers/SymbolConsistencySupervisor.java and 3 other locations - About 45 mins to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/observers/SymbolConsistencySupervisor.java on lines 42..49
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/observers/SymbolConsistencySupervisor.java on lines 69..76
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/observers/SymbolConsistencySupervisor.java on lines 81..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void handleHierarchyEvent(HierarchyEvent e) {
        if (e instanceof NodesDeletingEvent) {
            for (Node node: e.getAffectedNodes()) {
                if (node instanceof Event) {
Severity: Minor
Found in workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/observers/SymbolConsistencySupervisor.java and 1 other location - About 30 mins to fix
workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/observers/BundleConsistencySupervisor.java on lines 21..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status