Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private void selectSignals(SignalList signalList, Set<String> signals) {
        ListModel<String> signalListModel = signalList.getModel();
        List<Integer> indices = new ArrayList<>();
        for (int index = 0; index < signalListModel.getSize(); index++) {
            String signal = signalListModel.getElementAt(index);
Severity: Major
Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java and 2 other locations - About 1 hr to fix
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/InputPropernessDialog.java on lines 72..84
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/LocalSelfTriggeringDialog.java on lines 105..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private String getStateLabel(HandshakeParameters.State state) {
        switch (state) {
        case REQ0ACK0:
            return LABEL_PREFIX + REQ_LABEL + ASSERTED_LABEL;
        case REQ1ACK0:
Severity: Major
Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java and 1 other location - About 1 hr to fix
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java on lines 197..209

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private String getStateTooltip(HandshakeParameters.State state) {
        switch (state) {
        case REQ0ACK0:
            return TOOLTIP_PREFIX + REQ_LABEL + ASSERTED_SUFFIX;
        case REQ1ACK0:
Severity: Major
Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java and 1 other location - About 1 hr to fix
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java on lines 182..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private String getCheckAssertEnabledText() {
        String first = passiveRadioButton.isSelected() ? REQ_LABEL + ASSERTED_LABEL : ACK_LABEL + ASSERTED_LABEL;
        String second = passiveRadioButton.isSelected() ? ACK_LABEL + WITHDRAWN_LABEL : REQ_LABEL + ASSERTED_LABEL;
        return  first +  " must be enabled after " + second;
    }
Severity: Minor
Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java and 1 other location - About 55 mins to fix
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java on lines 301..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private String getCheckWithdrawEnabledText() {
        String first = passiveRadioButton.isSelected() ? REQ_LABEL + WITHDRAWN_LABEL : ACK_LABEL + WITHDRAWN_LABEL;
        String second = passiveRadioButton.isSelected() ? ACK_LABEL + ASSERTED_LABEL : REQ_LABEL + WITHDRAWN_LABEL;
        return  first +  " must be enabled after " + second;
    }
Severity: Minor
Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java and 1 other location - About 55 mins to fix
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/gui/HandshakeWizardDialog.java on lines 295..299

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status