Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this method.
Open

        return null;
Severity: Major
Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return Result.success(new CombinedChainOutput()
                    .applyVerificationParametersList(TRIVIAL_VIOLATION_PARAMETERS_LIST)
                    .applyMessage(HandshakeParameters.VIOLATION_PREFIX
                            + "Acknowledgements must be of opposite to requests type (outputs)."));
    Severity: Major
    Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return Result.success(new CombinedChainOutput()
                    .applyVerificationParametersList(TRIVIAL_VIOLATION_PARAMETERS_LIST)
                    .applyMessage(HandshakeParameters.VIOLATION_PREFIX
                            + "Acknowledgements must be of opposite to requests type (inputs)."));
      Severity: Major
      Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (outputSignals.containsAll(reqs) && !inputSignals.containsAll(acks)) {
            return Result.success(new CombinedChainOutput()
                    .applyVerificationParametersList(TRIVIAL_VIOLATION_PARAMETERS_LIST)
                    .applyMessage(HandshakeParameters.VIOLATION_PREFIX
                            + "Acknowledgements must be of opposite to requests type (inputs)."));
        Severity: Minor
        Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java and 1 other location - About 30 mins to fix
        workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java on lines 80..85

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 42.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (inputSignals.containsAll(reqs) && !outputSignals.containsAll(acks)) {
            return Result.success(new CombinedChainOutput()
                    .applyVerificationParametersList(TRIVIAL_VIOLATION_PARAMETERS_LIST)
                    .applyMessage(HandshakeParameters.VIOLATION_PREFIX
                            + "Acknowledgements must be of opposite to requests type (outputs)."));
        Severity: Minor
        Found in workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java and 1 other location - About 30 mins to fix
        workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/HandshakeChainTask.java on lines 74..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 42.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status