Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private PropertyDescriptor getPlayer1SymbolProperty(VisualPlayer1 event) {
        return new PropertyDeclaration<>(String.class, Player1.PROPERTY_SYMBOL,
                value -> {
                    Symbol symbol = null;
                    if (!value.isEmpty()) {
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java and 2 other locations - About 2 hrs to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/VisualGraph.java on lines 86..109
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java on lines 167..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private PropertyDescriptor getPlayer0SymbolProperty(VisualPlayer0 event) {
        return new PropertyDeclaration<>(String.class, Player0.PROPERTY_SYMBOL,
                value -> {
                    Symbol symbol = null;
                    if (!value.isEmpty()) {
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java and 2 other locations - About 2 hrs to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/VisualGraph.java on lines 86..109
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java on lines 198..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (node == null) {
            Container container = NamespaceHelper.getMathContainer(this,
                    getCurrentLevel());
            List<Symbol> symbols = new ArrayList<>(getMathModel().getSymbols(
                    container));
Severity: Minor
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java and 1 other location - About 55 mins to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/VisualGraph.java on lines 57..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } else if (node instanceof VisualPlayer0) {
            properties.add(getPlayer0SymbolProperty((VisualPlayer0) node));
        } else if (node instanceof VisualPlayer1) {
            properties.add(getPlayer1SymbolProperty((VisualPlayer1) node));
        }
Severity: Minor
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java and 1 other location - About 30 mins to fix
workcraft/WorkcraftCore/src/org/workcraft/gui/editor/GraphEditorPanel.java on lines 306..310

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status