Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void colorNodesBlue(Collection<VisualPlayer0> p0nodes,
            Collection<VisualPlayer1> p1nodes) {

        if (p0nodes == null) {
            p0nodes = new ArrayList<>();
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java and 1 other location - About 1 hr to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 35..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void colorNodesRed(Collection<VisualPlayer0> p0nodes,
            Collection<VisualPlayer1> p1nodes) {

        if (p0nodes == null) {
            p0nodes = new ArrayList<>();
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java and 1 other location - About 1 hr to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 61..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        while (p0iter.hasNext()) {
            Player0 tempP0 = p0iter.next();
            VisualPlayer0 tempvisualp0 = visualp0iter.next();
            OutputNode tempOutput = outputNodeiter.next();
            nameToId.put(pg.getName(tempP0), tempOutput.getId());
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java and 1 other location - About 1 hr to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 173..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        while (p1iter.hasNext()) {
            Player1 tempP1 = p1iter.next();
            VisualPlayer1 tempvisualp1 = visualp1iter.next();
            OutputNode tempOutput = outputNodeiter.next();
            nameToId.put(pg.getName(tempP1), tempOutput.getId());
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java and 1 other location - About 1 hr to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 160..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 80.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public void colorEdgesBlack(Collection<VisualConnection> edges) {

        if (edges == null) {
            edges = new ArrayList<>();
        }
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java and 2 other locations - About 50 mins to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 86..97
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 103..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public void colorEdgesRed(Collection<VisualConnection> edges) {

        if (edges == null) {
            edges = new ArrayList<>();
        }
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java and 2 other locations - About 50 mins to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 103..114
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 120..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public void colorEdgesBlue(Collection<VisualConnection> edges) {

        if (edges == null) {
            edges = new ArrayList<>();
        }
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java and 2 other locations - About 50 mins to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 86..97
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/commands/ParitySolverCommand.java on lines 120..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status