Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java

Summary

Maintainability
C
1 day
Test Coverage

Avoid too many return statements within this method.
Open

                return Result.cancel();
Severity: Major
Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return Result.exception(result.getCause());
    Severity: Major
    Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return Result.failure(new SynthesisOutput(output, null, null));
      Severity: Major
      Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return Result.success(synthesisOutput);
        Severity: Major
        Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private File getInputFile(Stg stg, File directory) {
        StgFormat format = StgFormat.getInstance();
        Exporter stgExporter = ExportUtils.chooseBestExporter(stg, format);
        if (stgExporter == null) {
            throw new NoExporterException(stg, format);
          Severity: Major
          Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java and 1 other location - About 3 hrs to fix
          workcraft/AtacsPlugin/src/org/workcraft/plugins/atacs/tasks/AtacsTask.java on lines 95..121

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 235.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (!isolatedPlaces.isEmpty()) {
            String refStr = ReferenceHelper.getNodesAsWrapString(stg, isolatedPlaces);
            String message = "Petrify does not support isolated marked places.\n\n"
                    + "Problematic places are:\n" + refStr;
          Severity: Major
          Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java and 1 other location - About 1 hr to fix
          workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/TransformationTask.java on lines 82..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (PetrifySettings.getOpenSynthesisStg()) {
            outFile = new File(directory, STG_FILE_NAME);
            command.add("-o");
            command.add(outFile.getAbsolutePath());
        } else {
          Severity: Minor
          Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java and 1 other location - About 40 mins to fix
          workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java on lines 104..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (PetrifySettings.getWriteLog()) {
            logFile = new File(directory, LOG_FILE_NAME);
            command.add("-log");
            command.add(logFile.getAbsolutePath());
        } else {
          Severity: Minor
          Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java and 1 other location - About 40 mins to fix
          workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java on lines 95..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                  if (PetrifySettings.getAdvancedMode()) {
            String tmp = DialogUtils.showInput("Additional parameters for Petrify:", extraArgs);
            if (tmp == null) {
                return Result.cancel();
            }
          Severity: Major
          Found in workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/SynthesisTask.java and 5 other locations - About 35 mins to fix
          workcraft/AtacsPlugin/src/org/workcraft/plugins/atacs/tasks/AtacsTask.java on lines 48..54
          workcraft/MpsatSynthesisPlugin/src/org/workcraft/plugins/mpsat_synthesis/tasks/MpsatTask.java on lines 104..110
          workcraft/MpsatVerificationPlugin/src/org/workcraft/plugins/mpsat_verification/tasks/MpsatTask.java on lines 76..82
          workcraft/MsfsmPlugin/src/org/workcraft/plugins/msfsm/tasks/ConversionTask.java on lines 42..48
          workcraft/PetrifyPlugin/src/org/workcraft/plugins/petrify/tasks/TransformationTask.java on lines 60..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status