Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java

Summary

Maintainability
D
2 days
Test Coverage

Avoid deeply nested control flow statements.
Open

                        for (Time ndin : postset) {
                            ndin.setStartTime(nd.getEndTime());
                        }
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if (i != null) {
                            m.setEndTime(i);
                        } else {
                            throw new TimeEstimationException(net.getNodeReference(m) + ".finish ("
                                    + m.getEndTime().toString() + ") is inconsistent with " + net.getNodeReference(nd)
    Severity: Major
    Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              for (Time ndin : preset) {
                            ndin.setEndTime(nd.getStartTime());
                        }
      Severity: Major
      Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (i != null) {
                            m.setEndTime(i);
                        } else {
                            throw new TimeEstimationException(net.getNodeReference(nd) + ".finish ("
                                    + nd.getEndTime().toString() + ") is inconsistent with " + net.getNodeReference(m)
        Severity: Major
        Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private void forwardBFSsonTimes(Time n) throws TimeOutOfBoundsException, TimeEstimationException {
        List<Time> working = new ArrayList<>();
        Collection<Node> nodes = scenario.getNodes(net);
        Map<Time, Integer> visit = new HashMap<>();
        working.add(n);
          Severity: Major
          Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java and 1 other location - About 7 hrs to fix
          workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java on lines 218..283

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 478.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private void backwardBFSsonTimes(Time n) throws TimeOutOfBoundsException, TimeEstimationException {
        List<Time> working = new ArrayList<>();
        Collection<Node> nodes = scenario.getNodes(net);
        Map<Time, Integer> visit = new HashMap<>();
        working.add(n);
          Severity: Major
          Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java and 1 other location - About 7 hrs to fix
          workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java on lines 152..216

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 478.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (Time time : net.getTimeNodes()) {
            if (!initial.contains(time)) {
                time.setStartTime(defTime);
            }
            if (!finalM.contains(time)) {
          Severity: Minor
          Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java and 1 other location - About 40 mins to fix
          workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/TimeAlg.java on lines 80..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  try {
            estimateEndTime(superIni);
        } catch (TimeEstimationException e) {
            net.remove(superIni);
            throw new TimeEstimationException("Fail to set estimated time for super initial node");
          Severity: Minor
          Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java and 1 other location - About 40 mins to fix
          workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java on lines 139..148

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      try {
                estimateStartTime(superFinal);
            } catch (TimeEstimationException e) {
                net.remove(superFinal);
                throw new TimeEstimationException("");
          Severity: Minor
          Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java and 1 other location - About 40 mins to fix
          workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java on lines 109..118

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                          if (first instanceof Time) {
                    Interval end = ((Time) first).getEndTime();
                    ((Time) first).setEndTime(Interval.getOverlapping(end, con.getTime()));
                }
          Severity: Minor
          Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BFSEntireEstimationAlg.java and 2 other locations - About 30 mins to fix
          workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/TimeAlg.java on lines 59..62
          workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/TimeAlg.java on lines 64..67

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status