Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void backwardDFSDurations(LinkedList<Time> visited) throws TimeOutOfBoundsException {
        for (Time t : getCausalPreset(visited.getLast(), scenario.getNodes(net))) {
            Interval i = null;
            // set default value for any t with unspecified duration.
            if (!t.getDuration().isSpecified()) {
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 122..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void forwardDFSDurations(LinkedList<Time> visited) throws TimeOutOfBoundsException {
        for (Time t : getCausalPostset(visited.getLast(), scenario.getNodes(net))) {
            Interval i = null;
            // set default value for any t with unspecified duration.
            if (!t.getDuration().isSpecified()) {
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 145..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void estimateStartTime(Node n) throws TimeOutOfBoundsException, TimeEstimationException {

        if (((Time) n).getStartTime().isSpecified()) {
            return;
        }
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 45..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void estimateEndTime(Node n) throws TimeOutOfBoundsException, TimeEstimationException {
        if (((Time) n).getEndTime().isSpecified()) {
            return;
        }
        LinkedList<Time> visited = new LinkedList<>();
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 70..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected LinkedList<Time> getCausalPreset(Time n, Collection<Node> nodes) {
        LinkedList<Time> preset = new LinkedList<>();
        LinkedList<Time> result = new LinkedList<>();

        for (TransitionNode[] pre : before) {
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 225..252

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected LinkedList<Time> getCausalPostset(Time n, Collection<Node> nodes) {
        LinkedList<Time> postset = new LinkedList<>();
        LinkedList<Time> result = new LinkedList<>();

        for (TransitionNode[] post : before) {
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 254..281

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (b[0]) {
            Interval s = ((Time) n).getStartTime();
            Collection<SONConnection> inputs = null;
            inputs = net.getInputPNConnections((MathNode) n);
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 1 hr to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 195..204

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (b[2]) {
            Interval e = ((Time) n).getEndTime();
            Collection<SONConnection> outputs = null;
            outputs = net.getOutputPNConnections((MathNode) n);
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 1 hr to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 178..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status