Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java

Summary

Maintainability
C
1 day
Test Coverage

Avoid deeply nested control flow statements.
Open

                            if (rlit.getVariable().getLabel().equals(llit.getVariable().getLabel())) {
                                foundSameLiteral = true;
                                sameNegation = llit.getNegation() == rlit.getNegation();
                                break;
                            }
Severity: Major
Found in workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            private static Dnf multiplyDnf(Dnf left, Dnf right) {
            Dnf result = new Dnf();
            for (DnfClause leftClause : left.getClauses()) {
                for (DnfClause rightClause : right.getClauses()) {
                    boolean foundSameLiteral;
    Severity: Major
    Found in workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java and 1 other location - About 3 hrs to fix
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 89..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 205.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            @Override
        public Dnf visit(Iff node) {
            Dnf a = node.getX().accept(this);
            Dnf b = node.getY().accept(this);
            negation = !negation;
    Severity: Major
    Found in workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java and 3 other locations - About 1 hr to fix
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 50..59
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 70..79
    workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java on lines 50..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            @Override
        public Dnf visit(Xor node) {
            Dnf a = node.getX().accept(this);
            Dnf b = node.getY().accept(this);
            negation = !negation;
    Severity: Major
    Found in workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java and 3 other locations - About 1 hr to fix
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 50..59
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 70..79
    workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java on lines 70..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            @Override
        public Dnf visit(Imply node) {
            negation = !negation;
            Dnf x = node.getX().accept(this);
            negation = !negation;
    Severity: Minor
    Found in workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java and 1 other location - About 50 mins to fix
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 61..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            @Override
        public Dnf visit(One node) {
            negation = !negation;
            Dnf result = negation ? new Dnf(new DnfClause()) : new Dnf();
            negation = !negation;
    Severity: Minor
    Found in workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java and 1 other location - About 35 mins to fix
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 17..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            @Override
        public Dnf visit(Not node) {
            negation = !negation;
            try {
                return node.getX().accept(this);
    Severity: Minor
    Found in workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java and 1 other location - About 30 mins to fix
    workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java on lines 30..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status