workcraft/workcraft

View on GitHub
workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method getTableCellRendererComponent has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        public Component getTableCellRendererComponent(JTable table, Object value,
                boolean isSelected, boolean hasFocus, int row, int col) {
Severity: Minor
Found in workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java - About 45 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            private boolean isActive(int row, int column) {
                if (column == 0) {
                    if (!mainTrace.isEmpty() && branchTrace.isEmpty()) {
                        return row == mainTrace.getPosition();
                    }
    workcraft/SonPlugin/src/org/workcraft/plugins/son/tools/SONSimulationTool.java on lines 804..815

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (solution.getMainTrace() != null) {
                mainTrace.addAll(solution.getMainTrace());
                while (mainTrace.getPosition() < solution.getMainTrace().getPosition()) {
                    if (!quietStepForward()) break;
                }
    workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java on lines 497..502

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (solution.getBranchTrace() != null) {
                branchTrace.addAll(solution.getBranchTrace());
                while (branchTrace.getPosition() < solution.getBranchTrace().getPosition()) {
                    if (!quietStepForward()) break;
                }
    workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SimulationTool.java on lines 490..495

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 11 locations. Consider refactoring.
    Open

            private final JLabel label = new JLabel() {
                @Override
                public void paint(Graphics g) {
                    g.setColor(getBackground());
                    g.fillRect(0, 0, getWidth(), getHeight());
    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/CycleAnalyserTool.java on lines 457..464
    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 440..447
    workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 536..543
    workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/CycleAnalyserTool.java on lines 349..356
    workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/EncodingConflictAnalyserTool.java on lines 242..249
    workcraft/StgPlugin/src/org/workcraft/plugins/stg/tools/StgSimulationTool.java on lines 217..224
    workcraft/WorkcraftCore/src/org/workcraft/gui/controls/FlatHeaderRenderer.java on lines 14..21
    workcraft/WorkcraftCore/src/org/workcraft/gui/lists/ColorListCellRenderer.java on lines 14..21
    workcraft/WorkcraftCore/src/org/workcraft/gui/properties/PropertyDeclarationRenderer.java on lines 13..20
    workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ColorTableCellRenderer.java on lines 11..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status