Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/WorkcraftCore/src/org/workcraft/serialisation/DefaultNodeDeserialiser.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method doFinalisation has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public void doFinalisation(Element element, Object instance, ReferenceResolver internalReferenceResolver,
            ReferenceResolver externalReferenceResolver, Class<?> currentLevel)
Severity: Minor
Found in workcraft/WorkcraftCore/src/org/workcraft/serialisation/DefaultNodeDeserialiser.java - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private boolean needDeserialisation(PropertyDescriptor desc) {
        return (desc.getPropertyType() != null) && (desc.getWriteMethod() != null) && (desc.getReadMethod() != null)
                && (desc.getReadMethod().getAnnotation(NoAutoSerialisation.class) == null)
                && (desc.getWriteMethod().getAnnotation(NoAutoSerialisation.class) == null);
    }
    Severity: Major
    Found in workcraft/WorkcraftCore/src/org/workcraft/serialisation/DefaultNodeDeserialiser.java and 1 other location - About 1 hr to fix
    workcraft/WorkcraftCore/src/org/workcraft/serialisation/DefaultNodeSerialiser.java on lines 45..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                        for (int i = 0; i < constructorParameters.length; i++) {
                        parameterTypes[i] = constructorParameters[i].getClass();
                    }
    Severity: Minor
    Found in workcraft/WorkcraftCore/src/org/workcraft/serialisation/DefaultNodeDeserialiser.java and 1 other location - About 30 mins to fix
    workcraft/WorkcraftCore/src/org/workcraft/dom/NodeFactory.java on lines 71..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status