Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java

Summary

Maintainability
C
1 day
Test Coverage

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java - About 30 mins to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if (srcTransition.getDirection() == TransitionEvent.Direction.RISE) {
                // Signal is stable high
                try {
                    dstModel.connect(signalStg.highPlace, dstTransition);
                    dstModel.connect(dstTransition, signalStg.highPlace);
    Severity: Major
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 1 hr to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 277..293

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (srcTransition.getDirection() == TransitionEvent.Direction.RISE) {
            // Signal goes from stable zero to stable one
            try {
                dstModel.connect(signalStg.lowPlace, dstTransition);
                dstModel.connect(dstTransition, signalStg.highPlace);
    Severity: Major
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 1 hr to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 254..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (exitNode instanceof State) {
            State exitState = (State) exitNode;
            StgPlace exitPlace = stateToPlaceMap.get(exitState);
            exitTransition = dstModel.createDummyTransition(getExitEventName(waveformName), null);
            try {
    Severity: Major
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 1 hr to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 128..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (entryNode instanceof State) {
            State entryState = (State) entryNode;
            StgPlace entryPlace = stateToPlaceMap.get(entryState);
            entryTransition = dstModel.createDummyTransition(getEntryEventName(waveformName), null);
            try {
    Severity: Major
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 1 hr to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 141..150

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private Map<Event, NamedTransition> convertEntryEvents(Waveform waveform) {
        Map<Event, NamedTransition> result = new HashMap<>();
        NamedTransition entryTransition = waveformToEntryExitInactiveMap.get(waveform).getFirst();
        for (EntryEvent entryEvent : srcModel.getEntries(waveform)) {
            result.put(entryEvent, entryTransition);
    Severity: Minor
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 45 mins to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 191..198

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private Map<Event, NamedTransition> convertExitEvents(Waveform waveform) {
        Map<Event, NamedTransition> result = new HashMap<>();
        NamedTransition exitTransition = waveformToEntryExitInactiveMap.get(waveform).getSecond();
        for (ExitEvent signalExit : srcModel.getExits(waveform)) {
            result.put(signalExit, exitTransition);
    Severity: Minor
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 45 mins to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 182..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (initialSignalState == Signal.State.HIGH) {
                highPlace.setTokens(1);
                lowPlace.setTokens(0);
            } else {
                //If the initial Signal State is unstable or stable, we default to 0. This is an arbitrary decision
    Severity: Minor
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 40 mins to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 63..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (initialSignalState == Signal.State.UNSTABLE) {
                stablePlace.setTokens(0);
                unstablePlace.setTokens(1);
            } else {
                stablePlace.setTokens(1);
    Severity: Minor
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 40 mins to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 70..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (fromNode instanceof EntryEvent) {
            Set<MathNode> preset = srcModel.getPreset(toNode);
            if ((preset.size() > 1) && preset.contains(fromNode)) {
                return true;
            }
    Severity: Minor
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 35 mins to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 341..346

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (toNode instanceof ExitEvent) {
            Set<MathNode> postset = srcModel.getPostset(fromNode);
            if ((postset.size() > 1) && postset.contains(toNode)) {
                return true;
            }
    Severity: Minor
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 35 mins to fix
    workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java on lines 335..340

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private SignalTransition.Direction convertWtgToStgDirection(TransitionEvent.Direction direction) {
        switch (direction) {
        case RISE: return SignalTransition.Direction.PLUS;
        case FALL: return SignalTransition.Direction.MINUS;
        default: return SignalTransition.Direction.TOGGLE;
    Severity: Minor
    Found in workcraft/WtgPlugin/src/org/workcraft/plugins/wtg/converter/WtgToStgConverter.java and 1 other location - About 30 mins to fix
    workcraft/StgPlugin/src/org/workcraft/plugins/stg/converters/DtdToStgConverter.java on lines 81..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status