Sign upLogin

workcraft/workcraft

View on GitHub
Star
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    @Override
    public void copyStyle(Stylable src) {
        super.copyStyle(src);
        if (src instanceof VisualQueueComponent) {
            QueueComponent srcComponent = ((VisualQueueComponent) src).getReferencedComponent();
Severity: Major
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 4 other locations - About 45 mins to fix
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/VisualCounterflowRegister.java on lines 142..150
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/VisualLogic.java on lines 95..103
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualCreditComponent.java on lines 68..76
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualSourceComponent.java on lines 84..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if (!slot.isMemExcited && slot.isFull) {
                    Shape tokenShape = transformShape(getTokenShape(i));
                    g.draw(tokenShape);
                    g.fill(tokenShape);
                }
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 2 other locations - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 180..184
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 185..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if (!slot.isHeadExcited && slot.isHead) {
                    Shape headShape = transformShape(getHeadShape(i));
                    g.draw(headShape);
                    g.fill(headShape);
                }
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 2 other locations - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 175..179
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 185..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if (slot.isMemExcited) {
                    Shape tokenShape = transformShape(getTokenShape(i));
                    g.draw(tokenShape);
                    if (slot.isFull) {
                        g.fill(tokenShape);
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 2 other locations - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 202..208
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 209..215

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public VisualQueueComponent(QueueComponent component) {
        super(component);
        if (component.getChildren().isEmpty()) {
            this.createInput(Positioning.LEFT);
            this.createOutput(Positioning.RIGHT);
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 1 other location - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualFunctionComponent.java on lines 19..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if (slot.isTailExcited) {
                    Shape tailShape = transformShape(getTailShape(i));
                    g.draw(tailShape);
                    if (slot.isTail) {
                        g.fill(tailShape);
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 2 other locations - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 195..201
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 202..208

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if (!slot.isTailExcited && slot.isTail) {
                    Shape tailShape = transformShape(getTailShape(i));
                    g.draw(tailShape);
                    g.fill(tailShape);
                }
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 2 other locations - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 175..179
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 180..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                if (slot.isHeadExcited) {
                    Shape headShape = transformShape(getHeadShape(i));
                    g.draw(headShape);
                    if (slot.isHead) {
                        g.fill(headShape);
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java and 2 other locations - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 195..201
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/components/VisualQueueComponent.java on lines 209..215

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status