wp-bootstrap/wp-bootstrap-navwalker

View on GitHub

Showing 150 of 150 total issues

Function start_el has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

        public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
            if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                $t = '';
                $n = '';
            } else {
Severity: Minor
Found in class-wp-bootstrap-navwalker.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start_el has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
            if ( isset( $args->item_spacing ) && 'discard' === $args->item_spacing ) {
                $t = '';
                $n = '';
            } else {
Severity: Major
Found in class-wp-bootstrap-navwalker.php - About 4 hrs to fix

    The class WP_Bootstrap_Navwalker has an overall complexity of 91 which is very high. The configured complexity threshold is 50.
    Open

        class WP_Bootstrap_Navwalker extends Walker_Nav_Menu {
    
            /**
             * Whether the items_wrap contains schema microdata or not.
             *
    Severity: Minor
    Found in class-wp-bootstrap-navwalker.php by phpmd

    Since: PHPMD 0.2.5

    The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

    Example:

    class Foo {
          public function bar() {
              if ($a == $b)  {
                  if ($a1 == $b1) {
                      fiddle();
                  } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                  }
              }
          }
          public function baz() {
              if ($a == $b) {
                  if ($a1 == $b1) {
                      fiddle();
                  } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                  }
              }
          }
          // Several other complex methods
      }

    Source: http://phpmd.org/rules/codesize.txt

    Function update_atts_for_linkmod_type has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

            private function update_atts_for_linkmod_type( $atts = array(), $linkmod_classes = array() ) {
                if ( ! empty( $linkmod_classes ) ) {
                    foreach ( $linkmod_classes as $link_class ) {
                        if ( ! empty( $link_class ) ) {
                            /*
    Severity: Minor
    Found in class-wp-bootstrap-navwalker.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File class-wp-bootstrap-navwalker.php has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * WP Bootstrap Navwalker
     *
     * @package WP-Bootstrap-Navwalker
    Severity: Minor
    Found in class-wp-bootstrap-navwalker.php - About 2 hrs to fix

      Function get_linkmod_type has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

              private function get_linkmod_type( $linkmod_classes = array() ) {
                  $linkmod_type = '';
                  // Loop through array of linkmod classes to handle their $atts.
                  if ( ! empty( $linkmod_classes ) ) {
                      foreach ( $linkmod_classes as $link_class ) {
      Severity: Minor
      Found in class-wp-bootstrap-navwalker.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fallback has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

              public static function fallback( $args ) {
                  if ( ! current_user_can( 'edit_theme_options' ) ) {
                      return;
                  }
      
      
      Severity: Minor
      Found in class-wp-bootstrap-navwalker.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fallback has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public static function fallback( $args ) {
                  if ( ! current_user_can( 'edit_theme_options' ) ) {
                      return;
                  }
      
      
      Severity: Minor
      Found in class-wp-bootstrap-navwalker.php - About 1 hr to fix

        Function separate_linkmods_and_icons_from_classes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                private function separate_linkmods_and_icons_from_classes( $classes, &$linkmod_classes, &$icon_classes, $depth ) {
                    // Loop through $classes array to find linkmod or icon classes.
                    foreach ( $classes as $key => $class ) {
                        /*
                         * If any special classes are found, store the class in it's
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The class WP_Bootstrap_Navwalker is not named in CamelCase.
        Open

            class WP_Bootstrap_Navwalker extends Walker_Nav_Menu {
        
                /**
                 * Whether the items_wrap contains schema microdata or not.
                 *
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php by phpmd

        Since: PHPMD 0.2

        It is considered best practice to use the CamelCase notation to name classes.

        Example:

        class class_name {
          }

        Source: http://phpmd.org/rules/controversial.txt

        Avoid variables with short names like $id. Configured minimum length is 3.
        Open

                public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php by phpmd

        Since: PHPMD 0.2

        Detects when a field, local, or parameter has a very short name.

        Example:

        class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

        Source: http://phpmd.org/rules/naming.txt

        Avoid variables with short names like $t. Configured minimum length is 3.
        Open

                        $t = '';
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php by phpmd

        Since: PHPMD 0.2

        Detects when a field, local, or parameter has a very short name.

        Example:

        class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

        Source: http://phpmd.org/rules/naming.txt

        Avoid variables with short names like $id. Configured minimum length is 3.
        Open

                            $id               = $args['container_id'] ? ' id="' . esc_attr( $args['container_id'] ) . '"' : '';
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php by phpmd

        Since: PHPMD 0.2

        Detects when a field, local, or parameter has a very short name.

        Example:

        class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

        Source: http://phpmd.org/rules/naming.txt

        Avoid variables with short names like $n. Configured minimum length is 3.
        Open

                        $n = '';
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php by phpmd

        Since: PHPMD 0.2

        Detects when a field, local, or parameter has a very short name.

        Example:

        class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

        Source: http://phpmd.org/rules/naming.txt

        Avoid variables with short names like $t. Configured minimum length is 3.
        Open

                        $t = '';
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php by phpmd

        Since: PHPMD 0.2

        Detects when a field, local, or parameter has a very short name.

        Example:

        class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

        Source: http://phpmd.org/rules/naming.txt

        Avoid variables with short names like $n. Configured minimum length is 3.
        Open

                        $n = '';
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php by phpmd

        Since: PHPMD 0.2

        Detects when a field, local, or parameter has a very short name.

        Example:

        class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

        Source: http://phpmd.org/rules/naming.txt

        Method start_el has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public function start_el( &$output, $item, $depth = 0, $args = null, $id = 0 ) {
        Severity: Minor
        Found in class-wp-bootstrap-navwalker.php - About 35 mins to fix

          Equals sign not aligned correctly; expected 1 space but found 9 spaces
          Open

                      $classes         = $this->flatten( array_map( $split_on_spaces, $classes ) );

          All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$fallback_output'.
          Open

                          echo $fallback_output;

          Inline comments must end in full-stops, exclamation marks, or question marks
          Open

                          // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
          Severity
          Category
          Status
          Source
          Language