Sign upLogin

wp-plugins/all-in-one-seo-pack

View on GitHub
Star
aioseop_bad_robots.php

Summary

Maintainability
D
2 days
Test Coverage

Function generate_htaccess_blocklist has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

        function generate_htaccess_blocklist() {
            if ( !$this->option_isset( 'htaccess_rules' ) ) return;
            if ( function_exists( 'apache_get_modules' ) ) {
                $modules = apache_get_modules();
                foreach( Array( 'mod_authz_host', 'mod_setenvif' ) as $m ) {
Severity: Minor
Found in aioseop_bad_robots.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __construct has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

        function __construct( ) {
            $this->name = __('Bad Bot Blocker', 'all-in-one-seo-pack');    // Human-readable name of the plugin
            $this->prefix = 'aiosp_bad_robots_';                        // option prefix
            $this->file = __FILE__;                                    // the current file
            parent::__construct();
Severity: Minor
Found in aioseop_bad_robots.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        function __construct( ) {
            $this->name = __('Bad Bot Blocker', 'all-in-one-seo-pack');    // Human-readable name of the plugin
            $this->prefix = 'aiosp_bad_robots_';                        // option prefix
            $this->file = __FILE__;                                    // the current file
            parent::__construct();
Severity: Major
Found in aioseop_bad_robots.php - About 2 hrs to fix

    Method generate_htaccess_blocklist has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function generate_htaccess_blocklist() {
            if ( !$this->option_isset( 'htaccess_rules' ) ) return;
            if ( function_exists( 'apache_get_modules' ) ) {
                $modules = apache_get_modules();
                foreach( Array( 'mod_authz_host', 'mod_setenvif' ) as $m ) {
    Severity: Minor
    Found in aioseop_bad_robots.php - About 1 hr to fix

      Function blocked_message has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              function blocked_message( $msg ) {
            if ( empty( $this->options["{$this->prefix}blocked_log"] ) ) $this->options["{$this->prefix}blocked_log"] = '';
            $this->options["{$this->prefix}blocked_log"] = date( 'Y-m-d H:i:s' ) . " {$msg}\n" . $this->options["{$this->prefix}blocked_log"];
            if ( $this->strlen( $this->options["{$this->prefix}blocked_log"] ) > 4096 ) {
                $end = $this->strrpos( $this->options["{$this->prefix}blocked_log"], "\n" );
      Severity: Minor
      Found in aioseop_bad_robots.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              function blocked_message( $msg ) {
            if ( empty( $this->options["{$this->prefix}blocked_log"] ) ) $this->options["{$this->prefix}blocked_log"] = '';
            $this->options["{$this->prefix}blocked_log"] = date( 'Y-m-d H:i:s' ) . " {$msg}\n" . $this->options["{$this->prefix}blocked_log"];
            if ( $this->strlen( $this->options["{$this->prefix}blocked_log"] ) > 4096 ) {
                $end = $this->strrpos( $this->options["{$this->prefix}blocked_log"], "\n" );
      Severity: Major
      Found in aioseop_bad_robots.php and 1 other location - About 6 hrs to fix
      aioseop_sitemap.php on lines 618..627

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 216.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  $help_text = Array(
                'block_bots' =>   __( 'Block requests from user agents that are known to misbehave.', 'all-in-one-seo-pack' ),
                'block_refer' =>  __( 'Block referral spam.', 'all-in-one-seo-pack' ),
                'track_blocks'=>  __( 'Log and show recent requests from blocked bots.', 'all-in-one-seo-pack' ),
                'htaccess_rules'=>__( 'Block bad robots via Apaache .htaccess rules. Warning: this will change your web server configuration, make sure you are able to edit this file manually as well.', 'all-in-one-seo-pack' ),
      Severity: Major
      Found in aioseop_bad_robots.php and 1 other location - About 2 hrs to fix
      aioseop_opengraph.php on lines 41..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status