writesdown/app-cms

View on GitHub
backend/controllers/PostController.php

Summary

Maintainability
C
1 day
Test Coverage

Function actionBulkAction has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionBulkAction()
    {
        if (Yii::$app->request->post('action') === Post::STATUS_PUBLISH) {
            foreach (Yii::$app->request->post('ids', []) as $id) {
                $model = $this->findModel($id);
Severity: Minor
Found in backend/controllers/PostController.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function actionCreate has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionCreate($type)
    {
        $model = new Post();
        $postType = $this->findPostType($type);
        $model->comment_status = Option::get('default_comment_status');
Severity: Minor
Found in backend/controllers/PostController.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method actionBulkAction has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionBulkAction()
    {
        if (Yii::$app->request->post('action') === Post::STATUS_PUBLISH) {
            foreach (Yii::$app->request->post('ids', []) as $id) {
                $model = $this->findModel($id);
Severity: Minor
Found in backend/controllers/PostController.php - About 1 hr to fix

    Method actionCreate has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionCreate($type)
        {
            $model = new Post();
            $postType = $this->findPostType($type);
            $model->comment_status = Option::get('default_comment_status');
    Severity: Minor
    Found in backend/controllers/PostController.php - About 1 hr to fix

      Function actionUpdate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function actionUpdate($id)
          {
              $model = $this->findModel($id);
              $this->getPermission($model);
              $postType = $model->postType;
      Severity: Minor
      Found in backend/controllers/PostController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status