writesdown/app-cms

View on GitHub
common/models/Post.php

Summary

Maintainability
D
3 days
Test Coverage

Post has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class Post extends ActiveRecord
{
    public $username;

    const COMMENT_STATUS_OPEN = 'open';
Severity: Minor
Found in common/models/Post.php - About 2 hrs to fix

    File Post.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * @link http://www.writesdown.com/
     * @copyright Copyright (c) 2015 WritesDown
     * @license http://www.writesdown.com/license/
    Severity: Minor
    Found in common/models/Post.php - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if (!$this->postType
                  || !Yii::$app->user->can($this->postType->permission)
                  || (!Yii::$app->user->can('editor') && Yii::$app->user->id !== $this->author)
                  || (!Yii::$app->user->can('author') && $this->status === self::STATUS_REVIEW)
              ) {
      Severity: Major
      Found in common/models/Post.php - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function getNextPost($sameType = true, $sameTerm = false)
            {
                /* @var $query \yii\db\ActiveQuery */
                $query = static::find()
                    ->from(['post' => $this->tableName()])
        Severity: Major
        Found in common/models/Post.php and 1 other location - About 6 hrs to fix
        common/models/Post.php on lines 360..387

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 206.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function getPrevPost($sameType = true, $sameTerm = false)
            {
                /* @var $query \yii\db\ActiveQuery */
                $query = static::find()
                    ->from(['post' => $this->tableName()])
        Severity: Major
        Found in common/models/Post.php and 1 other location - About 6 hrs to fix
        common/models/Post.php on lines 304..331

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 206.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function getNextPostLink($title = '{title}', $sameType = true, $sameTerm = false, $options = [])
            {
                if ($nextPost = $this->getNextPost($sameType, $sameTerm)) {
                    $title = preg_replace_callback('/\\{([\w\-\/]+)\\}/', function ($matches) use ($nextPost) {
                        $attribute = $matches[1];
        Severity: Major
        Found in common/models/Post.php and 1 other location - About 2 hrs to fix
        common/models/Post.php on lines 396..409

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function getPrevPostLink($title = '{title}', $sameType = true, $sameTerm = false, $options = [])
            {
                if ($prevPost = $this->getPrevPost($sameType, $sameTerm)) {
                    $title = preg_replace_callback('/\\{([\w\-\/]+)\\}/', function ($matches) use ($prevPost) {
                        $attribute = $matches[1];
        Severity: Major
        Found in common/models/Post.php and 1 other location - About 2 hrs to fix
        common/models/Post.php on lines 340..353

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 123.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function setMeta($name, $value)
            {
                if (is_array($value) || is_object($value)) {
                    $value = Json::encode($value);
                }
        Severity: Major
        Found in common/models/Post.php and 1 other location - About 1 hr to fix
        common/models/Media.php on lines 212..229

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function upMeta($name, $value)
            {
                /* @var $model \common\models\PostMeta */
                $model = PostMeta::findOne(['name' => $name, 'post_id' => $this->id]);
        
        
        Severity: Minor
        Found in common/models/Post.php and 1 other location - About 30 mins to fix
        common/models/Media.php on lines 238..250

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status