Sign upLogin

writesdown/app-cms

View on GitHub
Star
modules/sitemap/frontend/controllers/DefaultController.php

Summary

Maintainability
D
1 day
Test Coverage

Function actionIndex has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public function actionIndex()
    {
        /* @var $postType PostType */
        /* @var $post Post */
        /* @var $taxonomies Taxonomy[] */
Severity: Minor
Found in modules/sitemap/frontend/controllers/DefaultController.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method actionIndex has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionIndex()
    {
        /* @var $postType PostType */
        /* @var $post Post */
        /* @var $taxonomies Taxonomy[] */
Severity: Major
Found in modules/sitemap/frontend/controllers/DefaultController.php - About 3 hrs to fix

    Method actionView has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionView($type, $slug, $page = 1)
    {
        /* @var $taxonomy Taxonomy */
        /* @var $postType PostType */
        /* @var $posts Post[] */
    Severity: Major
    Found in modules/sitemap/frontend/controllers/DefaultController.php - About 3 hrs to fix

      Function actionView has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function actionView($type, $slug, $page = 1)
    {
        /* @var $taxonomy Taxonomy */
        /* @var $postType PostType */
        /* @var $posts Post[] */
      Severity: Minor
      Found in modules/sitemap/frontend/controllers/DefaultController.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $this->redirect(['/site/not-found']);
      Severity: Major
      Found in modules/sitemap/frontend/controllers/DefaultController.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status