wtg/shuttle-signups

View on GitHub

Showing 31 of 31 total issues

Avoid deeply nested control flow statements.
Open

                        if (riders[user].includes(rcs_id + "-guest")) {
                            riders.splice(user, 1);
                            user--;
                            guestsRemoved++;
                        }
Severity: Major
Found in routes/unsignup-shuttle.js - About 45 mins to fix

    Function constructor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      constructor(arg?:any){
        console.log("ShuttleGroup created.");
        this._id= arg && arg._id || "fillme";
        this.destination= arg && arg.destination || [
            {
    Severity: Minor
    Found in web/app/dashboard/shuttle-group.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                if (docs[i].waitlist[user].includes(rcs_id + "-guest")) {
                  numGuests++;
                }
    Severity: Major
    Found in routes/get-user-shuttles.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if (riders[user].includes(rcs_id + "-guest")) {
                                  riders.splice(user, 1);
                                  user--;
                                  guestsRemoved++;
                              }
      Severity: Major
      Found in routes/unsignup-shuttle.js - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

                        return;
        Severity: Major
        Found in routes/signup-shuttle.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return;
          Severity: Major
          Found in routes/signup-shuttle.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return;
            Severity: Major
            Found in routes/signup-shuttle.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return;
              Severity: Major
              Found in routes/signup-shuttle.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return;
                Severity: Major
                Found in routes/signup-shuttle.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return;
                  Severity: Major
                  Found in routes/signup-shuttle.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return;
                    Severity: Major
                    Found in routes/signup-shuttle.js - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language