Sign upLogin

x4team/project-lvl1-s490

View on GitHub
Star

Showing 5 of 5 total issues

Function startGames has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const startGames = () => {
  console.log('\nPlease select the game you want:'
   + '\n1) brain-calc'
   + '\n2) brain-even'
   + '\n3) brain-gcd'
Severity: Minor
Found in src/menu.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const genEvenData = () => {
  const number = getRandomInt(1, 100);
  const answer = isEven(number) ? 'yes' : 'no';
  const question = String(number);
  return [answer, question];
    Severity: Major
    Found in src/games/even.js and 1 other location - About 1 hr to fix
    src/games/prime.js on lines 14..19

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const genPrimeData = () => {
  const number = getRandomInt(2, 100);
  const answer = isPrime(number) ? 'yes' : 'no';
  const question = String(number);
  return [answer, question];
    Severity: Major
    Found in src/games/prime.js and 1 other location - About 1 hr to fix
    src/games/even.js on lines 7..12

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function makeGame has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const makeGame = (gameDataFunc, description) => {
  console.log('\nWelcome to the Brain Games!');
  const userName = readlineSync.question('\nMay I have your name? ');
  console.log(`\nHello, ${userName}!`);
  console.log(`\n${description}`);
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Function makeGame has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const makeGame = (gameDataFunc, description) => {
  console.log('\nWelcome to the Brain Games!');
  const userName = readlineSync.question('\nMay I have your name? ');
  console.log(`\nHello, ${userName}!`);
  console.log(`\n${description}`);
      Severity: Minor
      Found in src/index.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language