Sign upLogin

xchem/XChemExplorer

View on GitHub
Star
xce/gui_scripts/settings_preferences.py

Summary

Maintainability
D
2 days
Test Coverage

File settings_preferences.py has 627 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
import subprocess
import sys

from PyQt4 import QtCore
Severity: Major
Found in xce/gui_scripts/settings_preferences.py - About 1 day to fix

    Function settings has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        def settings(self, xce_object):
        # set XCE version
        xce_object.xce_version = "v1.9.4"

        # general settings
    Severity: Minor
    Found in xce/gui_scripts/settings_preferences.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function settings has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def settings(self, xce_object):
        # set XCE version
        xce_object.xce_version = "v1.9.4"

        # general settings
    Severity: Minor
    Found in xce/gui_scripts/settings_preferences.py - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      xce_object.labxchem_directory_current = "/" + os.path.join(
                    *xce_object.current_directory.split("/")[1:9]
      Severity: Major
      Found in xce/gui_scripts/settings_preferences.py and 3 other locations - About 55 mins to fix
      xce/gui_scripts/settings_preferences.py on lines 49..50
      xce/gui_scripts/settings_preferences.py on lines 58..59
      xce/gui_scripts/settings_preferences.py on lines 61..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      xce_object.labxchem_directory = "/" + os.path.join(
                    *xce_object.current_directory.split("/")[1:6]
      Severity: Major
      Found in xce/gui_scripts/settings_preferences.py and 3 other locations - About 55 mins to fix
      xce/gui_scripts/settings_preferences.py on lines 49..50
      xce/gui_scripts/settings_preferences.py on lines 52..53
      xce/gui_scripts/settings_preferences.py on lines 61..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      xce_object.labxchem_directory = "/" + os.path.join(
                    *xce_object.current_directory.split("/")[1:8]
      Severity: Major
      Found in xce/gui_scripts/settings_preferences.py and 3 other locations - About 55 mins to fix
      xce/gui_scripts/settings_preferences.py on lines 52..53
      xce/gui_scripts/settings_preferences.py on lines 58..59
      xce/gui_scripts/settings_preferences.py on lines 61..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      xce_object.labxchem_directory_current = "/" + os.path.join(
                    *xce_object.current_directory.split("/")[1:7]
      Severity: Major
      Found in xce/gui_scripts/settings_preferences.py and 3 other locations - About 55 mins to fix
      xce/gui_scripts/settings_preferences.py on lines 49..50
      xce/gui_scripts/settings_preferences.py on lines 52..53
      xce/gui_scripts/settings_preferences.py on lines 58..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status