xcv58/Custom-JavaScript-for-Websites-2

View on GitHub

Showing 11 of 12 total issues

AppStore has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class AppStore {
  store: Store

  constructor (store) {
    makeObservable(this, {
Severity: Minor
Found in src/js/stores/AppStore.tsx - About 3 hrs to fix

    File AppStore.tsx has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { action, computed, observable, makeObservable } from 'mobx'
    import { encodeSource, decodeSource, getHosts, setHosts } from 'libs'
    import isEqual from 'lodash.isequal'
    import sizeof from 'object-sizeof'
    import { js } from 'js-beautify'
    Severity: Minor
    Found in src/js/stores/AppStore.tsx - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export default observer(() => {
        const { draft, onRemoveDraft } = useStore().AppStore
        if (!draft) {
          return null
        }
      Severity: Major
      Found in src/js/components/RemoveDraft.tsx and 1 other location - About 2 hrs to fix
      src/js/components/Goto.tsx on lines 6..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export default observer(() => {
        const { differentURL, goTo } = useStore().AppStore
        if (!differentURL) {
          return null
        }
      Severity: Major
      Found in src/js/components/Goto.tsx and 1 other location - About 2 hrs to fix
      src/js/components/RemoveDraft.tsx on lines 6..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        constructor (store) {
          makeObservable(this, {
            extraOpen: observable,
            extra: observable,
            include: observable,
      Severity: Major
      Found in src/js/stores/IncludeStore.tsx and 1 other location - About 1 hr to fix
      src/js/stores/NewPatternStore.tsx on lines 8..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        constructor (store) {
          makeObservable(this, {
            open: observable,
            pattern: observable,
            validPattern: computed,
      Severity: Major
      Found in src/js/stores/NewPatternStore.tsx and 1 other location - About 1 hr to fix
      src/js/stores/IncludeStore.tsx on lines 12..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function NewPatternDialog has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const NewPatternDialog = observer(() => {
        const navigate = useNavigate()
        const { NewPatternStore } = useStore()
        const { closeDialog, error, validPattern, pattern } = NewPatternStore
        return (
      Severity: Minor
      Found in src/js/components/NewPattern.tsx - About 1 hr to fix

        Function constructor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor (store) {
            makeObservable(this, {
              mode: observable,
              loading: observable,
              autoSaveHandle: observable,
        Severity: Minor
        Found in src/js/stores/AppStore.tsx - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  <Button
                    color='secondary'
                    onClick={() => {
                      AppStore.removeHost({ reload: true })
                      closeDialog()
          Severity: Major
          Found in src/js/components/Reset.tsx and 1 other location - About 1 hr to fix
          src/js/components/Reset.tsx on lines 33..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  <Button
                    color='primary'
                    onClick={() => {
                      AppStore.removeHost({ reload: false })
                      closeDialog()
          Severity: Major
          Found in src/js/components/Reset.tsx and 1 other location - About 1 hr to fix
          src/js/components/Reset.tsx on lines 43..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function onMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          const onMessage = async (message, sender, sendResponse) => {
            const { domain } = message
            try {
              const tab = await getActiveTab()
              const url = domain ? getURL({ url: domain }) : getURL(tab)
          Severity: Minor
          Found in src/js/background.tsx - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language