Sign upLogin

xeBuz/Flask-Validator

View on GitHub
Star

Showing 49 of 49 total issues

Cyclomatic complexity is too high in method __validate. (8)
Open

    def __validate(self, target, value, oldvalue, initiator):
        """ Method executed when the event 'set' is triggered.

        :param target: Object triggered
        :param value: New value
Severity: Minor
Found in flask_validator/validator.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function __validate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def __validate(self, target, value, oldvalue, initiator):
        """ Method executed when the event 'set' is triggered.

        :param target: Object triggered
        :param value: New value
Severity: Minor
Found in flask_validator/validator.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, field, allow_smtputf8=True,check_deliverability=True, allow_empty_local=False,
Severity: Major
Found in flask_validator/constraints/internet.py - About 50 mins to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, field, allow_null, throw_exception, message,
    Severity: Minor
    Found in flask_validator/validator.py - About 45 mins to fix

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, field, version=4, allow_null=True, throw_exception=False, message=None):
      Severity: Minor
      Found in flask_validator/constraints/others.py - About 35 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, field, max_length=None, min_length=0, throw_exception=False, message=None):
        Severity: Minor
        Found in flask_validator/constraints/numbers.py - About 35 mins to fix

          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, field, allow_null=True, throw_exception=False, message=None, interpolate_message=True):
          Severity: Minor
          Found in flask_validator/validator.py - About 35 mins to fix

            Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(self, field, regex, allow_null=False, throw_exception=False, message=None):
            Severity: Minor
            Found in flask_validator/constraints/others.py - About 35 mins to fix

              Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(self, field, ipv6=False, allow_null=True, throw_exception=False, message=None):
              Severity: Minor
              Found in flask_validator/constraints/internet.py - About 35 mins to fix

                Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def __init__(self, field, range_valid, allow_null=True, throw_exception=False, message=None):
                Severity: Minor
                Found in flask_validator/constraints/others.py - About 35 mins to fix

                  Line too long (109 > 79 characters)
                  Open

                          FlaskValidator.__init__(self, field, allow_null, throw_exception, message, interpolate_message, self)
                  Severity: Minor
                  Found in flask_validator/validator.py by pep8

                  Limit all lines to a maximum of 79 characters.

                  There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

                  Line too long (115 > 79 characters)
                  Open

                                                                   "Field {field} - Value {value} - Oldvalue {oldvalue} - Key {key}")
                  Severity: Minor
                  Found in examples/example.py by pep8

                  Limit all lines to a maximum of 79 characters.

                  There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

                  Trailing whitespace
                  Open

                  """ Internet Validators
                  Severity: Minor
                  Found in flask_validator/constraints/internet.py by pep8

                  Trailing whitespace is superfluous.

                  The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

                  Line too long (94 > 79 characters)
                  Open

                          allow_empty_local (bool) Set to True to allow an empty local part (i.e. @example.com),
                  Severity: Minor
                  Found in flask_validator/constraints/internet.py by pep8

                  Limit all lines to a maximum of 79 characters.

                  There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

                  Line too long (95 > 79 characters)
                  Open

                      def __init__(self, field, version=4, allow_null=True, throw_exception=False, message=None):
                  Severity: Minor
                  Found in flask_validator/constraints/others.py by pep8

                  Limit all lines to a maximum of 79 characters.

                  There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

                  Line too long (97 > 79 characters)
                  Open

                      def __init__(self, field, range_valid, allow_null=True, throw_exception=False, message=None):
                  Severity: Minor
                  Found in flask_validator/constraints/others.py by pep8

                  Limit all lines to a maximum of 79 characters.

                  There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

                  Expected 2 blank lines after class or function definition, found 1
                  Open

                  db.create_all()
                  Severity: Minor
                  Found in examples/example.py by pep8

                  Separate top-level function and class definitions with two blank lines.

                  Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                  Blank line contains whitespace
                  Open
                  Severity: Minor
                  Found in flask_validator/constraints/comparison.py by pep8

                  Trailing whitespace is superfluous.

                  The warning returned varies on whether the line itself is blank,
for easier filtering for those who want to indent their blank lines.

Okay: spam(1)\n#
W291: spam(1) \n#
W293: class Foo(object):\n    \n    bang = 12

                  Line too long (86 > 79 characters)
                  Open

                  from .financial import ValidateCreditCard, ValidateCurrency, ValidateIBAN, ValidateBIC
                  Severity: Minor
                  Found in flask_validator/constraints/__init__.py by pep8

                  Limit all lines to a maximum of 79 characters.

                  There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

                  Missing whitespace after ','
                  Open

                      def __init__(self, field, allow_smtputf8=True,check_deliverability=True, allow_empty_local=False,
                  Severity: Minor
                  Found in flask_validator/constraints/internet.py by pep8

                  Each comma, semicolon or colon should be followed by whitespace.

                  Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]
                  Severity
                  Category
                  Status
                  Source
                  Language