Sign upLogin

xebialabs-community/xld-azure-app-services-plugin

View on GitHub
Star

Showing 32 of 32 total issues

Function update_db_conn_settings has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def update_db_conn_settings(self, resource_group, site_name, location,
Severity: Minor
Found in src/main/jython/azure_app_services/client/__init__.py - About 45 mins to fix

    Function discover_service_plans has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def discover_service_plans(client, ctx, descriptor, base_id, resource_group):
    Severity: Minor
    Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

      Function deploy_triggered_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def deploy_triggered_webjob(self, webjob_name, site_name, executable_file_name, schedule, zip_file_path):
      Severity: Minor
      Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

        Function create_app_service_plan has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def create_app_service_plan(self, resource_group, name, location, sku, worker_size):
        Severity: Minor
        Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

          Function perform_discovery has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def perform_discovery(subscription, ctx, resource_group_descriptor, web_app_module_descriptor, service_plan_descriptor):
          Severity: Minor
          Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

            Function deploy_continuous_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def deploy_continuous_webjob(self, webjob_name, site_name, executable_file_name, is_singleton, zip_file_path):
            Severity: Minor
            Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

              Function discover_webapps has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def discover_webapps(client, ctx, descriptor, base_id, resource_group):
              Severity: Minor
              Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

                Function _deploy_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def _deploy_webjob(self, webjob_name, site_name, executable_file_name, zip_file_path, webjob_service_type="triggeredwebjobs" ):
                Severity: Minor
                Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      [discover_webapps(client, ctx,webapp_descriptor, "%s/%s" % (base_id, rg.name), rg.name) for rg in resource_groups]
                  Severity: Minor
                  Found in src/main/jython/azure_app_services/inspect.py and 1 other location - About 30 mins to fix
                  src/main/jython/azure_app_services/inspect.py on lines 76..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 32.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      [discover_service_plans(client, ctx, service_plan_descriptor, "%s/%s" % (base_id, rg.name), rg.name) for rg in resource_groups]
                  Severity: Minor
                  Found in src/main/jython/azure_app_services/inspect.py and 1 other location - About 30 mins to fix
                  src/main/jython/azure_app_services/inspect.py on lines 75..75

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 32.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function _execute_http_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def _execute_http_request(self, request_builder, error_checking=True):
        response = self._execute_http_request_return_response(request_builder)
        if error_checking:
            AzureClient._check_return_code(response)
        else:
                  Severity: Minor
                  Found in src/main/jython/azure_app_services/client/__init__.py - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function update_general_settings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def update_general_settings(self, resource_group, site_name, location, settings):
        wsuc_details = WebSiteUpdateConfigurationDetails()
        wsuc_details.setUse32BitWorkerProcess(settings.platform_32bit)
        wsuc_details.setAlwaysOn(settings.always_on)
        if settings.java_version:
                  Severity: Minor
                  Found in src/main/jython/azure_app_services/client/__init__.py - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language