Sign upLogin

xebialabs-community/xld-azure-app-services-plugin

View on GitHub
Star
src/main/jython/azure_app_services/client/__init__.py

Summary

Maintainability
D
3 days
Test Coverage

AzureClient has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class AzureClient:
    def __init__(self, subscription_id, tenant_id, client_id, client_key, ftp_user, ftp_password, base_url, management_url,
                 active_directory_url):
        self.subscription_id = subscription_id
        self.tenant_id = tenant_id
Severity: Major
Found in src/main/jython/azure_app_services/client/__init__.py - About 7 hrs to fix

    File __init__.py has 352 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    #
# Copyright 2019 XEBIALABS
#
# Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
#
    Severity: Minor
    Found in src/main/jython/azure_app_services/client/__init__.py - About 4 hrs to fix

      Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, subscription_id, tenant_id, client_id, client_key, ftp_user, ftp_password, base_url, management_url,
      Severity: Major
      Found in src/main/jython/azure_app_services/client/__init__.py - About 1 hr to fix

        Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, platform_32bit=True, always_on=False, net_framework_version="", php_version="", python_version="",
        Severity: Major
        Found in src/main/jython/azure_app_services/client/__init__.py - About 1 hr to fix

          Function update_db_conn_settings has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def update_db_conn_settings(self, resource_group, site_name, location,
          Severity: Minor
          Found in src/main/jython/azure_app_services/client/__init__.py - About 45 mins to fix

            Function deploy_triggered_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def deploy_triggered_webjob(self, webjob_name, site_name, executable_file_name, schedule, zip_file_path):
            Severity: Minor
            Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

              Function create_app_service_plan has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def create_app_service_plan(self, resource_group, name, location, sku, worker_size):
              Severity: Minor
              Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                Function deploy_continuous_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def deploy_continuous_webjob(self, webjob_name, site_name, executable_file_name, is_singleton, zip_file_path):
                Severity: Minor
                Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                  Function _deploy_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def _deploy_webjob(self, webjob_name, site_name, executable_file_name, zip_file_path, webjob_service_type="triggeredwebjobs" ):
                  Severity: Minor
                  Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                    Function _execute_http_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def _execute_http_request(self, request_builder, error_checking=True):
        response = self._execute_http_request_return_response(request_builder)
        if error_checking:
            AzureClient._check_return_code(response)
        else:
                    Severity: Minor
                    Found in src/main/jython/azure_app_services/client/__init__.py - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function update_general_settings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def update_general_settings(self, resource_group, site_name, location, settings):
        wsuc_details = WebSiteUpdateConfigurationDetails()
        wsuc_details.setUse32BitWorkerProcess(settings.platform_32bit)
        wsuc_details.setAlwaysOn(settings.always_on)
        if settings.java_version:
                    Severity: Minor
                    Found in src/main/jython/azure_app_services/client/__init__.py - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        def stop_website(self, resource_group, site_name):
        if self._get_website_state(resource_group, site_name) != WebSiteState.Stopped:
            self._web_site_operations().stop(resource_group, site_name, None)
                    Severity: Major
                    Found in src/main/jython/azure_app_services/client/__init__.py and 1 other location - About 1 hr to fix
                    src/main/jython/azure_app_services/client/__init__.py on lines 198..200

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 42.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        def start_website(self, resource_group, site_name):
        if self._get_website_state(resource_group, site_name) != WebSiteState.Running:
            self._web_site_operations().start(resource_group, site_name, None)
                    Severity: Major
                    Found in src/main/jython/azure_app_services/client/__init__.py and 1 other location - About 1 hr to fix
                    src/main/jython/azure_app_services/client/__init__.py on lines 194..196

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 42.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        def remove_triggered_webjob(self, webjob_name, site_name):
        request = self._kudu_request(site_name, "triggeredwebjobs/%s" % webjob_name).delete()
        self._execute_http_request(request)
                    Severity: Major
                    Found in src/main/jython/azure_app_services/client/__init__.py and 1 other location - About 1 hr to fix
                    src/main/jython/azure_app_services/client/__init__.py on lines 389..391

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 39.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        def remove_continuous_webjob(self, webjob_name, site_name):
        request = self._kudu_request(site_name, "continuouswebjobs/%s" % webjob_name).delete()
        self._execute_http_request(request)
                    Severity: Major
                    Found in src/main/jython/azure_app_services/client/__init__.py and 1 other location - About 1 hr to fix
                    src/main/jython/azure_app_services/client/__init__.py on lines 385..387

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 39.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        def continuous_webjob_exists(self, webjob_name, site_name):
        request = self._kudu_request(site_name, "continuouswebjobs/%s" % webjob_name)
        return self._execute_http_request(request, error_checking=False)
                    Severity: Major
                    Found in src/main/jython/azure_app_services/client/__init__.py and 1 other location - About 1 hr to fix
                    src/main/jython/azure_app_services/client/__init__.py on lines 393..395

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 39.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        def triggered_webjob_exists(self, webjob_name, site_name):
        request = self._kudu_request(site_name, "triggeredwebjobs/%s" % webjob_name)
        return self._execute_http_request(request, error_checking=False)
                    Severity: Major
                    Found in src/main/jython/azure_app_services/client/__init__.py and 1 other location - About 1 hr to fix
                    src/main/jython/azure_app_services/client/__init__.py on lines 397..399

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 39.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status