xebialabs-community/xld-azure-app-services-plugin

View on GitHub
src/main/jython/azure_app_services/inspect.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function discover_resource_groups has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def discover_resource_groups(client, ctx, descriptor, webapp_descriptor, service_plan_descriptor, base_id):
Severity: Minor
Found in src/main/jython/azure_app_services/inspect.py - About 45 mins to fix

    Function discover_service_plans has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def discover_service_plans(client, ctx, descriptor, base_id, resource_group):
    Severity: Minor
    Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

      Function perform_discovery has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def perform_discovery(subscription, ctx, resource_group_descriptor, web_app_module_descriptor, service_plan_descriptor):
      Severity: Minor
      Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

        Function discover_webapps has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def discover_webapps(client, ctx, descriptor, base_id, resource_group):
        Severity: Minor
        Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              [discover_webapps(client, ctx,webapp_descriptor, "%s/%s" % (base_id, rg.name), rg.name) for rg in resource_groups]
          Severity: Minor
          Found in src/main/jython/azure_app_services/inspect.py and 1 other location - About 30 mins to fix
          src/main/jython/azure_app_services/inspect.py on lines 76..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              [discover_service_plans(client, ctx, service_plan_descriptor, "%s/%s" % (base_id, rg.name), rg.name) for rg in resource_groups]
          Severity: Minor
          Found in src/main/jython/azure_app_services/inspect.py and 1 other location - About 30 mins to fix
          src/main/jython/azure_app_services/inspect.py on lines 75..75

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status