Sign upLogin

xebialabs-community/xlr-bitbucket-plugin

View on GitHub
Star
src/main/resources/stash/CommitTrigger.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function findNewCommit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def findNewCommit(oldCommitMap, newCommitMap):
    branch = None
    commitId = None

    # loop over new map branches
Severity: Minor
Found in src/main/resources/stash/CommitTrigger.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    for newBranch, newCommitId in newCommitMap.iteritems():
        # check if branch exists in old map
        if newBranch in oldCommitMap:
            oldCommitId = oldCommitMap[newBranch]
            # compare commit ids
Severity: Major
Found in src/main/resources/stash/CommitTrigger.py and 1 other location - About 3 hrs to fix
src/main/resources/bitbucket/CommitTrigger.py on lines 21..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Whitespace before '('
Open

            print ("Bitbucket triggered release for %s-%s" % (branch, commitId))
Severity: Minor
Found in src/main/resources/stash/CommitTrigger.py by pep8

Avoid extraneous whitespace.

Avoid extraneous whitespace in the following situations:
- before the open parenthesis that starts the argument list of a
  function call.
- before the open parenthesis that starts an indexing or slicing.

Okay: spam(1)
E211: spam (1)

Okay: dict['key'] = list[index]
E211: dict ['key'] = list[index]
E211: dict['key'] = list [index]

There are no issues that match your filters.

Category
Status